From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C91FB5A71 for ; Wed, 16 Dec 2015 14:48:40 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 16 Dec 2015 05:48:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,437,1444719600"; d="scan'208";a="861976002" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by fmsmga001.fm.intel.com with ESMTP; 16 Dec 2015 05:48:35 -0800 Date: Wed, 16 Dec 2015 21:48:50 +0800 From: Yuanhan Liu To: Santosh Shukla Message-ID: <20151216134850.GU29571@yliu-dev.sh.intel.com> References: <1450098032-21198-1-git-send-email-sshukla@mvista.com> <1450098032-21198-6-git-send-email-sshukla@mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450098032-21198-6-git-send-email-sshukla@mvista.com> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [ [PATCH v2] 05/13] virtio: change io_base datatype from uint32_t to uint64_type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2015 13:48:41 -0000 On Mon, Dec 14, 2015 at 06:30:24PM +0530, Santosh Shukla wrote: > In x86 case io_base to store ioport address not more than 65535 ioports. i.e..0 > to ffff but in non-x86 case in particular arm64 it need to store more than 32 > bit address so changing io_base datatype from 32 to 64. > > Signed-off-by: Santosh Shukla > --- > drivers/net/virtio/virtio_ethdev.c | 2 +- > drivers/net/virtio/virtio_pci.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index d928339..620e0d4 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1291,7 +1291,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev) > return -1; > > hw->use_msix = virtio_has_msix(&pci_dev->addr); > - hw->io_base = (uint32_t)(uintptr_t)pci_dev->mem_resource[0].addr; > + hw->io_base = (uint64_t)(uintptr_t)pci_dev->mem_resource[0].addr; I'd suggest to move the io_base assignment (and cast) into virtio_ioport_init() so that we could do the correct cast there, say cast it to uint32_t for X86, and uint64_t for others. --yliu > > /* Reset the device although not necessary at startup */ > vtpci_reset(hw); > diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h > index 3f4ff80..f3e4178 100644 > --- a/drivers/net/virtio/virtio_pci.h > +++ b/drivers/net/virtio/virtio_pci.h > @@ -169,7 +169,7 @@ struct virtqueue; > > struct virtio_hw { > struct virtqueue *cvq; > - uint32_t io_base; > + uint64_t io_base; > uint32_t guest_features; > uint32_t max_tx_queues; > uint32_t max_rx_queues; > @@ -231,7 +231,7 @@ outl_p(unsigned int data, unsigned int port) > #endif > > #define VIRTIO_PCI_REG_ADDR(hw, reg) \ > - (unsigned short)((hw)->io_base + (reg)) > + (unsigned long)((hw)->io_base + (reg)) > > #define VIRTIO_READ_REG_1(hw, reg) \ > inb((VIRTIO_PCI_REG_ADDR((hw), (reg)))) > -- > 1.7.9.5