From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org, i.maximets@samsung.com, s.dyasly@samsung.com
Subject: Re: [dpdk-dev] [PATCH] Unlink existing unused sockets at start up
Date: Thu, 17 Dec 2015 19:59:06 +0800 [thread overview]
Message-ID: <20151217115906.GE29571@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1450326062-105574-1-git-send-email-zhihong.wang@intel.com>
On Wed, Dec 16, 2015 at 11:21:02PM -0500, Zhihong Wang wrote:
> This patch unlinks existing unused sockets (which cause new bindings to fail, e.g. vHost PMD) to ensure smooth startup.
> In a lot of cases DPDK applications are terminated abnormally without proper resource release. Therefore, DPDK libs should be able to deal with unclean boot environment.
No, I thought we have made it clear, that a library should not remove a
file given by the application, the application should.
(BTW, please wrap your commit log in 80 chars).
--yliu
prev parent reply other threads:[~2015-12-17 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 4:21 Zhihong Wang
2015-12-17 11:47 ` Ilya Maximets
2015-12-18 2:39 ` Wang, Zhihong
2015-12-18 6:17 ` Ilya Maximets
2015-12-21 3:31 ` Wang, Zhihong
2015-12-17 11:59 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151217115906.GE29571@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=s.dyasly@samsung.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).