From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f174.google.com (mail-pf0-f174.google.com
 [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id DC2BD5A24
 for <dev@dpdk.org>; Mon,  4 Jan 2016 00:06:00 +0100 (CET)
Received: by mail-pf0-f174.google.com with SMTP id 65so147219865pff.3
 for <dev@dpdk.org>; Sun, 03 Jan 2016 15:06:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding;
 bh=sCV1BcoZSeo5tw/wrl3LfWDycXS1pQow+FlstOzhF7A=;
 b=WK9QkCR4pm1SCHejXgJKocXrs8oyWQjiLHhbkomiMmohrDb3cwFKm6eRMaq43GFedh
 d9i9Evi6sPtz2sBqegDiZuYkdCJZTDH3O/vwfOuU8rp7rpUmF6ce5R25DEiGWbjP9+O2
 xfLdoY8fEwG79WC6M2pUXCHQ5dS0AURFkskIR8QRiPUUUq3dgWG8pMy86BqzE/x1IQz5
 t9oNVusAPu89QBZw4jM6ZABLc9YnlfwPKqRWzrEUnTsabStDpxi4NljUz2xGHigf/kng
 SNTHmSv5HBssa/nheffmiaIxvz/49gSra1Vc94n1M3sNvQL9LVW9lxr0f/Qbg3yqQ8i1
 6aEw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=sCV1BcoZSeo5tw/wrl3LfWDycXS1pQow+FlstOzhF7A=;
 b=cEqqNzW5rC+FqWfanktjWtmEDy7WXq0MW1jgGkkE2SCIjEd+bfzsEjX26Mm7HQokIv
 OSr0weTeu+xPrdEHLSkHp+dkBxRS+0e7lB/jX//0eu+dBMGpLHKXJE4tiqMiSX5XIYUG
 2PrHBm2eT5Fp6lkmdcyIVm0F1OsAS24JJ50VlhPH+5KOtSq6hwI2R+NrEJw+bBXaaPu8
 DfDyL2m3ES/kryUcfmdz2BqoZcCtgdDvs+XBMDUo2aY2nNLtQ2CS0JhGhQp4gZ/QV7hs
 Q8Mm8o2JZ1VcuA+ycMjlWYzOugFW4Gk1VIe6DUt1kY8jMWoBnx4AD5mpa5IdZeEoYH+I
 ZNsw==
X-Gm-Message-State: ALoCoQlr9GQrE5zIFCK1Hn2vOTFZDP7WQPOLD0Z30HnmwW9YZaHZRMMS6DmpjourwQohZ0YAS3lblGflBrA+PlLy70wjvC2R9A==
X-Received: by 10.98.17.149 with SMTP id 21mr104377849pfr.15.1451862360171;
 Sun, 03 Jan 2016 15:06:00 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id x75sm54376366pfi.95.2016.01.03.15.05.59
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 03 Jan 2016 15:05:59 -0800 (PST)
Date: Sun, 3 Jan 2016 15:06:09 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Matthew Hall <mhall@mhcomputing.net>
Message-ID: <20160103150609.0cfd0787@xeon-e3>
In-Reply-To: <56899BA7.60006@mhcomputing.net>
References: <674FEFDF-70BD-4C02-947B-10C9F9FC862C@intel.com>
 <56899BA7.60006@mhcomputing.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PKTGEN] OK to reindent the pktgen (mix of tabs and
 spaces, etc.)?
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Jan 2016 23:06:01 -0000

On Sun, 3 Jan 2016 14:07:35 -0800
Matthew Hall <mhall@mhcomputing.net> wrote:

> On 1/3/16 9:09 AM, Wiles, Keith wrote:
> > Pktgen is setup for tabs for 4 (with replace tabs with spaces), using tab stop of 8 is just wrong IMO :-)
> > Just started using kdevelop instead of eclipse, so I may have corrupted the style some :-(
> 
> The problem I found was a number of files had an incompatible 
> combination of the two formats.
> 
> Personally, I agree tab size 4 w/ spaces instead of tabs is easiest to 
> read and edit. But I could live with any space based system for the most 
> part. I find tab based systems are unpleasant because it is difficult 
> when tabs are used for one thing and spaces for another thing. This 
> annoyance also applies to DPDK and the kernel but it's too late for both 
> of those.
> 
> > At least it is suppose to be done that way. I will reformat the code (with tabs=4) and have a look at the output.
> 
> Thanks this will be a big help.
> 
> > I can run the astyle on the code and look at the output, if it looks OK I will submit it to the repo
> 
> Sounds great... it is no big hurry on my end but I want to start with a 
> clean slate before I get invested in the code, and start really hitting 
> it hard, and making patches.
> 
> The formatting command I provided is not perfect, but it was the best I 
> could do with the various popular indenter tools to try to avoid messing 
> up too much of the rest of the good code in the files in the process of 
> fixing the format.
> 
> You might be able to improve it a bit further w/ some additional 
> experimentation since you are the original maintainer of the code 
> obviously. Or perhaps reformat using tools in Eclipse or KDevelop? I had 
> good luck w/ Eclipse before with special configuration but I only mostly 
> used the Java mode not the C / C++ one which is less good.
> 
> Matthew.

Since DPDK mostly follows kernel style, why should this program be different?