From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id D51028E9D for ; Mon, 4 Jan 2016 18:29:41 +0100 (CET) Received: by mail-pf0-f172.google.com with SMTP id e65so152264632pfe.1 for ; Mon, 04 Jan 2016 09:29:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=7CP3RNq23MceucQclB1zrGAhTX7ccuQmC7dcxjROEYU=; b=to0p0/Io3jLNNnH5dy0LdUm2mxDLOV/HgCjtkBRxCEdZld1NNVrxAYU4C6hQjY4zqP CYSq8uaZPJbSPvvY0FZnolZKmGifH6z4bJntWe0Weo960jq0UNKabCeie3wVun4P/6PN OSrUROYkVXUhZexPFvoCc3YXMLSQKMR4cYIGBBJmrrE3hfME/8LfAd+fvD+frUOXPqYQ lImcCrAMEkrw+3HUme1tRjpjcWwCKPn0qbgcu9UsSn1mxagNuDVGBydQOe/ChUXH6pLt 1zFt+vPz6fFOccRv1b8d4HN0Nfo9+mpK9c0cH7+0+USLUpeGCPMeXmPO19HwLNKvCWu9 VSDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=7CP3RNq23MceucQclB1zrGAhTX7ccuQmC7dcxjROEYU=; b=El2wo8VEmEgnhC36b0YL6usksOcWTc1A5lGZAmmEaurV8P2n36u807C4J40AgpjFf1 hWY7FaWjOhQ/831ZUAHgF8bx8jRDPHrye5Fg36TFLM53EgAf0ybiY4idSJzFwanPqWae j8PdjEIYclF71/UcSfVdgsrkEiEvn3BXvl1yKSzGTRP1dZzYgBpQjcNZjrM7NWgunslB pYkpmqyoD8s1sbmqibH+DzYMbZx08V9Tv5AiWNqEy48OvrRl8jqy7fA3V+r6lUIqDmye dWNF+dYnNVqNxSs/VaoUhI3128xY6xD/esx+BT/Wu+y++LKT8nvGCQ+MNq/Kpavq0Iv2 ZoEw== X-Gm-Message-State: ALoCoQmqJt2IOP5miK1ChJhoe4hMTvwklHhnHSLVTUVJUzdOnQtww2DR76cnH0BGmDS/xisNKwpyE1C+VdgBen1aw5tyFU/h7Q== X-Received: by 10.98.44.209 with SMTP id s200mr120053300pfs.2.1451928580382; Mon, 04 Jan 2016 09:29:40 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id 7sm122411877pfb.62.2016.01.04.09.29.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jan 2016 09:29:40 -0800 (PST) Date: Mon, 4 Jan 2016 09:29:49 -0800 From: Stephen Hemminger To: "Xie, Huawei" Message-ID: <20160104092949.7ea534f9@xeon-e3> In-Reply-To: References: <20151222035041.GA7532@pxdev.xzpeter.org> <1450982292-129560-1-git-send-email-huawei.xie@intel.com> <1450982292-129560-5-git-send-email-huawei.xie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 4/4] virtio: check if any kernel driver is manipulating the device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2016 17:29:42 -0000 On Mon, 4 Jan 2016 09:02:53 +0000 "Xie, Huawei" wrote: > > + PMD_INIT_LOG(ERR, > Better change ERR to INFO and revise the message followed, since user > might not want to use this device for DPDK. > > + "%s(): kernel driver is manipulating this device." \ > > + " Please unbind the kernel driver.", __func__); The addition of __func__ here is redundant since this is already in PMD_INIT_LOG macro.