From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id 55A4D91F0 for ; Tue, 5 Jan 2016 06:14:26 +0100 (CET) Received: by mail-pf0-f178.google.com with SMTP id q63so177962222pfb.0 for ; Mon, 04 Jan 2016 21:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=ypl1St1a3JwlNkJPqijTr2c+jUQsYm6j+2uNrcj6JwM=; b=Mo8WdsBwAheXrEqUxemaWspL7A8pYZpLxhxy27zw6ov+U7C4Bk4OZE1BITnPbC3/SU 2VIEXNaXwvsDk6cULRKvfQMNDTX3ybY9lFUDG3fBFuxVObVVnc6x8YgYVB/g38FUjIkJ Vuw67PjzqKhOrgWt8Pp6E7YhXTdm4NKXyB3QgaHLeMS84GF6c8Hvp9Ie0UUtf+Op7cfX OEdkPJ5zNtKo7ePeN2QjWM1O6dIQveo4YQHTQDnqDOItxpyPWXWKuT3tWcE/nzHj3I3/ vrTlnBTNAaCYpNtiOgI7u6uk4HSvtQ9/EzZ6DIvagDj/i3uf8SaWvW3TMz17e7Quiily NqsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=ypl1St1a3JwlNkJPqijTr2c+jUQsYm6j+2uNrcj6JwM=; b=LbCCyMSHSJP/P1vHwcX0ZRSrQ3UsUIWu57+lVaQeQuGVuI0VRc4PiiULd2zsD/psQ0 bYbwLC3pmbLUkRJqNfwdE57K3sIJdiz+xZoF7Yr3tTE+PU5vnQiXfyzrnI1ont46YkCh BHsDqJXd/1OjxRZhuXUkK+AmcuzdJnZFzEZyt0Pu/A8tLJQ+EycnBXFPE42q0SoOXvwH WCGyXVYA/s30ZJ93phfI+MZX27yn5xS8MxD2JxkMEDXCs0QOPExvXHaVZGNnoktdWX92 CBilhV/k7QkIpVeXgNip4+VQ2hzDLfLB8745JB7aECD0b3jczh/WhR4gLZ1ao1RkYGnv TTZA== X-Gm-Message-State: ALoCoQmYiMoEYGxlEXpqgmbeAL0TJv5Xv2kWziZa/C+brn8TNKqvegyW3+9apTgCHczf9thQ5P99Cvsj32NAqTCbMGpChr4YWg== X-Received: by 10.98.70.193 with SMTP id o62mr126128650pfi.32.1451970865430; Mon, 04 Jan 2016 21:14:25 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id rt6sm129998343pab.17.2016.01.04.21.14.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jan 2016 21:14:25 -0800 (PST) Date: Mon, 4 Jan 2016 21:14:31 -0800 From: Stephen Hemminger To: Yong Wang Message-ID: <20160104211431.7331034d@xeon-e3> In-Reply-To: <1451960899-26881-4-git-send-email-yongwang@vmware.com> References: <1451960899-26881-1-git-send-email-yongwang@vmware.com> <1451960899-26881-4-git-send-email-yongwang@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 3/4] vmxnet3: add TSO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jan 2016 05:14:26 -0000 On Mon, 4 Jan 2016 18:28:18 -0800 Yong Wang wrote: > + mbuf = txq->cmd_ring.buf_info[eop_idx].m; > + if (unlikely(mbuf == NULL)) > + rte_panic("EOP desc does not point to a valid mbuf"); > + else The unlikely is really not needed with rte_panic since it is declared with cold attribute which has same effect. Else is unnecessary because rte_panic never returns.