From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] fix checkpatch errors
Date: Tue, 5 Jan 2016 10:27:52 +0800 [thread overview]
Message-ID: <20160105022752.GG26062@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E36031CD068@SHSMSX103.ccr.corp.intel.com>
On Tue, Jan 05, 2016 at 02:21:12AM +0000, Tan, Jianfeng wrote:
>
>
> > -----Original Message-----
> > From: Xie, Huawei
> > Sent: Monday, January 4, 2016 9:52 AM
> > To: dev@dpdk.org
> > Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei
> > Subject: [PATCH] fix checkpatch errors
> >
> > Signed-off-by: Huawei Xie <huawei.xie@intel.com>
> ...
> > mbuf_poolname_build(sock_id, pool_name, sizeof(pool_name));
> > - return (rte_mempool_lookup((const char *)pool_name));
> > + return rte_mempool_lookup((const char *)pool_name);
>
> Hi Huawei,
>
> Assume this patch is to solve below error (reported by checkpatch):
> ERROR: return is not a function, parentheses are not required
>
> So maybe above fix is not necessary? Involve more people to discuss.
This fix is good to me.
> And please include the error message in the commit message.
+1
--yliu
next prev parent reply other threads:[~2016-01-05 2:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 1:51 Huawei Xie
2016-01-05 2:21 ` Tan, Jianfeng
2016-01-05 2:27 ` Yuanhan Liu [this message]
2016-01-05 2:43 ` Xie, Huawei
2016-01-05 10:21 ` Mcnamara, John
2016-01-05 16:20 ` Xie, Huawei
2016-01-26 17:26 ` [dpdk-dev] [PATCH v2] " Huawei Xie
2016-01-27 18:16 ` Thomas Monjalon
2016-01-28 3:09 ` Xie, Huawei
2016-01-28 8:04 ` Thomas Monjalon
2016-01-28 8:38 ` Xie, Huawei
2016-01-28 9:43 ` Panu Matilainen
2016-01-27 13:58 ` [dpdk-dev] [PATCH v3] remove extra parentheses in return statement Huawei Xie
2016-02-10 14:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105022752.GG26062@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).