From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 75830941C for ; Wed, 6 Jan 2016 01:51:58 +0100 (CET) Received: by mail-pf0-f176.google.com with SMTP id 78so231625915pfw.2 for ; Tue, 05 Jan 2016 16:51:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=RpXvR3ZnbIieGcbc1elLl8ndfSc9rSUPNDeyVz5cKu8=; b=dg8LezstmkzCUOb7RBmdXAis/IXSmGeDjE6pp2fQ6haZSkFy6+493lDH2bIHE0pbYk N1TjFhkil9FmE8ywIN1qjFI+gAbpjV9dxbYZKOGAwq9Nm1xhG3erYKll76BnnPCMV7rV b/mLpjdvGh4bQR1U73CjVtCZ+wPDRX7oBgZ94r7YtJyaXzxvG98JX7XDdIGM8Ofdeiit j3DrNDrQe61UeRclA+Roi1yLWOtIrYdg7XtiLnWQlpvtQCvhoWfFlyV5/f7nvVGveaq8 xYaPWx+EQGVtWV4Rgt8QYp4eID2ywxBCm/5CUzSxuzPGPwJCr5A2Zfb3/bjI+LNzvzv9 fvrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=RpXvR3ZnbIieGcbc1elLl8ndfSc9rSUPNDeyVz5cKu8=; b=eOtI0sFM1WcpZ0g7gR9uNFL1Fgc0nArt6Ax1MoNzgBMfkFxcBpXkwswVj6PoQ14qX2 V49hFNlElRLCpwvhPDNg3vmDKD9XsegcIiiIHJs/dIhTWqMThTJRYnu2yFWJYo3vXx6G gDNfKN2DHTZR+6Q6D2WttPRIo3frhUkVBv3sDy+gAm9jfNavYDaXVkQW/hiFo9NzqN6K p68U5zaIGPzaWE/biePOlWCA+LP3IqxLAbhfy8nlt6dj7Xh/BX7SJnvQCnoqg1gvzmhM 3HBidBC9cj7F7IRUimKug7GCJSTR/2EN1T596McSf4mHQGt9+ewC9oMS8mQ5FEdHkKtH eR9A== X-Gm-Message-State: ALoCoQkiEhS2fTZ2B6pmiGk3gzo+RW1YdewT1qJeZvhmzcwUkpNNOxaIMWwCAsqBBJq2u+N27YsiQYF2bmREKau6u2wPJI2eAw== X-Received: by 10.98.76.72 with SMTP id z69mr137689664pfa.35.1452041517728; Tue, 05 Jan 2016 16:51:57 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id o15sm104336819pfa.66.2016.01.05.16.51.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jan 2016 16:51:57 -0800 (PST) Date: Tue, 5 Jan 2016 16:52:05 -0800 From: Stephen Hemminger To: Yong Wang Message-ID: <20160105165205.1945e308@xeon-e3> In-Reply-To: <1452039178-15635-5-git-send-email-yongwang@vmware.com> References: <1452039178-15635-1-git-send-email-yongwang@vmware.com> <1452039178-15635-5-git-send-email-yongwang@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 4/4] vmxnet3: announce device offload capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2016 00:51:58 -0000 On Tue, 5 Jan 2016 16:12:58 -0800 Yong Wang wrote: > > /* return 0 means link status changed, -1 means not changed */ > @@ -819,7 +831,7 @@ vmxnet3_dev_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vid, int on) > else > VMXNET3_CLEAR_VFTABLE_ENTRY(hw->shadow_vfta, vid); > > - /* don't change active filter if in promiscious mode */ > + /* don't change active filter if in promiscuous mode */ Maybe send a first patch in series with these message and comment cleanups? Makes the review easier, and aides bisection.