From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0055.outbound.protection.outlook.com [65.55.169.55]) by dpdk.org (Postfix) with ESMTP id ECA9695C2 for ; Wed, 6 Jan 2016 18:34:16 +0100 (CET) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.Jacob@caviumnetworks.com; Received: from localhost.localdomain (122.167.53.249) by BN3PR0701MB1718.namprd07.prod.outlook.com (10.163.39.17) with Microsoft SMTP Server (TLS) id 15.1.361.13; Wed, 6 Jan 2016 17:34:13 +0000 Date: Wed, 6 Jan 2016 23:03:51 +0530 From: Jerin Jacob To: "Andralojc, WojciechX" Message-ID: <20160106173348.GA23478@localhost.localdomain> References: <1450354363-102022-1-git-send-email-wojciechx.andralojc@intel.com> <3FD2C4106EAA5C43838688C653B6E2AFDB8422@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <3FD2C4106EAA5C43838688C653B6E2AFDB8422@IRSMSX103.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.167.53.249] X-ClientProxiedBy: BM1PR01CA0055.INDPRD01.PROD.OUTLOOK.COM (25.163.199.27) To BN3PR0701MB1718.namprd07.prod.outlook.com (25.163.39.17) X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1718; 2:zyGYTbHSTNoWGCotXbOfe/v3MM+lKvZsp3raUwucq64yKtrqA63+HSM3SLNHpmLbEBSMsljl1tWhVyFqH2NVi6khrc7C4hb0p3KNVw5ugZtlSXWwB6w4Tyw/vlXnQ6sHy4FNt0G5ch7Wxopwh2pvIw==; 3:7ia2gzwP5ogOk79UksugITwN9cSjVzyUTiuPEaNk4lPrrSDaaRNwIMN51gFwti4P1dPKz8Y0/jGKT0wbixO1oK9Sd/Wqd/2TeyojZrnIRP4oizaC6t6oYa4TrPvpwEbK; 25:wlP2qtdsk+jVOVDuzMf9dAG27LHVlmv/Aq9qhexgUSjamA7+JFXdNiAq4YpvlNpzwiWnMYJ9vyhpJYk4SL4h/LLtrBhjASQgPmGt4vOgI+e0H8WHhiv1IlOrdRMeRzr67K9WU/3Hr6SBTRd+83JyXhOe7fi/U4oiLTwRRZtsjdfHoZiMeQ8+TbwZ30+Oy9UNdRl1DV1S2iT6Quq2i9pIUx2c9rR32tKoizKlEvs7PadZs58W/HCIxhN11pbvLmRTFTPH8G07l6od1+toROuCLw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0701MB1718; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1718; 20:lrLdBrWrJ7QZnvM8q9kVbOSDdyh+2yI80EORVOT1x9PPnzQb2HEM2BVvZB1aUBfzocuYqDxSiN178rk7UKMzhtmfGE18Cr0rQzlwpP2H6D79wdRvzEf0A0+Q4f+ON4DgAqqXA+t1kY2QPVzJ0X7OCDwpoIRzCveUZrtsUinsjzs4gz0H3ntYougerxS10sFFduDJD0hkXhIBuAyN58eF4tx6/riDuv1zX94CjkKTkGk7/r0tKM3JXwgaKPTra8oSkiI+Nr1jYy/i0hwXO9yucf0jZbqaUqgyvnjjrjdHoC0U+6NUYd248WrIgSv/eXm4Cw6Y/dGB3W+3UvYiGswHjciNVT6YzcvcxjfPZWlfsO8qHNrfX/yigbWpX8jjBkFBkDxKRgiEaENAYfwQ5hcHx5uHlLooYUBLY6Irj0/MRFSUYze5c2lfyrfZUYyty32zSFsbyQdDC4uXWtF7SYFVxRySb3ti3/TT2GeACSdMeQ5tj4z1NDNlwukAljaoG7K7jdutVJHCaXEUVZZtsMV5heCiq4U7ninJZ750cP5thp2MaLv9RvNe6YuNmWUu9ksDNalyWaHSsrCPdTrZ1ZmpaVG5j6dx7nPs4MPr1cOBEPU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(3002001)(10201501046); SRVR:BN3PR0701MB1718; BCL:0; PCL:0; RULEID:; SRVR:BN3PR0701MB1718; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1718; 4:l0ltiN6sgGxCZyH6ruRMd/CczcaBy6O8PI8MWkxF/L8a8MMwZO1cGMdv9beykqMZxlwGgGqOKNe1oNvNcojiMjV8K38s9RJu95tWN5vfK4zdNnLJy+cy0MoWa52Ql0qsom6rezBaBvao7V0SdNQ3I9XRX++hdPSYhCIlbVIQhv8aW8xmog8i3RkHhBTnuE3zqgkfhLMVRG0ZRDVsuzsev9BOYGM8hQObe7NGv3PSdPKz5YbCen/hVD0/Mcr6D+IXATN5eJD9vuj39FMlXtccZ0a+vgd2mVfsNFcwLkStXPixfJxz6TyMWUKObyFJuN2gDvuOOZTyoyDlfPCuf+8SWTUGIbkwOOE+I3nxY3r3RAjrCSuu1iOOuDCnls1bDGgl X-Forefront-PRVS: 0813C68E65 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(377454003)(199003)(189002)(24454002)(4001350100001)(50986999)(54356999)(87976001)(97756001)(105586002)(5004730100002)(50466002)(122386002)(101416001)(5008740100001)(47776003)(76176999)(61506002)(1076002)(189998001)(40100003)(5890100001)(83506001)(81156007)(92566002)(2950100001)(6116002)(77096005)(46406003)(86362001)(554214002)(97736004)(66066001)(3846002)(110136002)(5001960100002)(42186005)(106356001)(33656002)(19580395003)(19580405001)(586003)(23726003)(4326007)(1096002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0701MB1718; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: caviumnetworks.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR0701MB1718; 23:SXlUKU0iUOom+Dl02qrVPPEdbHU89+zvRw2NRpz?= =?us-ascii?Q?GxPM6MMrFHiuagoKPrmOJy5Ne3JQ6pZ/rfLOhm10xLRfGd8p58tonDYvV3lL?= =?us-ascii?Q?MMgvHjvO+cy9HCKt7wo0/sTYM2wqRWeG0QkwoxxRuJFk4C3QtKblhGubkAgt?= =?us-ascii?Q?Kknr6dC3rXVet/zVqh3KNG1RhIHGMdiNRGxsrseUiDKMPDZFD1WWxZvsT1lh?= =?us-ascii?Q?liBCnK35822T40Wqhn/AHMYjp+os6x9GMrNvZ63g47f1VJmCyEc8PcOnMM5K?= =?us-ascii?Q?5Qtimoqztl4fQL3aaRibau7+/Eiq0RdJIv9DT5jFWCsbQniXyf/rD+eyOwHu?= =?us-ascii?Q?MIGJ6D8mUaK2y51eFK9jenw7P9KCwWF0JU9InxaBiJopABTxxXCDP8mfXT5x?= =?us-ascii?Q?P1LYE/AARqknoLGJn6LDSS4dIoBa0K2swW6+NEoxhmt4+IJkIGjGmvTFcNkR?= =?us-ascii?Q?88wwOw0fLCIMj+LKvMRtV9qXek9GBHutE3DARgAEeP4rQpFahfvvAtwpO+yM?= =?us-ascii?Q?xCEPRR6GBzZBog1trjljunkXRcDF8ZU5TdvK/uqoO+Lru9fui59/bjaB0maL?= =?us-ascii?Q?apA6bQJ1LTcjZ5kubMVfIpJ5/Vz0FW4FGE+C8/5nZSE8/7iJRZI3RbqNHLTG?= =?us-ascii?Q?qag6c3YCTcdz5NXDXEbeZMW8JhnUsQ+OLn767c2cBNDk4MgKgkfRldlr0g84?= =?us-ascii?Q?v3SxAlBWn8BYIkzwIOKLHSrHsTgP7YyyQSC0skDjTp1wSuYia+PwSD4TdMms?= =?us-ascii?Q?IlBxBhuP3e8BTPByIQdA+NyrphSQLLY5MygOr3k3uk2NeQxuaZio1fBhtmuq?= =?us-ascii?Q?zSttSpUAhRPvToN+WKG0lncICr4r5GTcnOE512t4GO2VlXtoAS8LzrVcPVoc?= =?us-ascii?Q?z7gJi42i6IcqDdV+8dyd+DAXhmoQAwhKbDk8dgYk7C83TwMP3mXm/PouPwwo?= =?us-ascii?Q?x7DKeePqZSLFCmDVhQRO8N/72B7454llSdhybhuenPNT6/xKKTyVV9xnQEW9?= =?us-ascii?Q?SXmp0H5+MGq+sLFpqkeDUWSaA406+fSQ8FUzb/53Po+t786IGuohtW+LsF8o?= =?us-ascii?Q?KwBBgRnLamFqaVy0yjF9wp9VLRO2O3dUnSlaBrDzM0r4bSaJa4SGJIAblpss?= =?us-ascii?Q?68hBqEcVBl+E75bTCAEbvRPriU8wlD6iYtR/XIwqUP2Ftjbz0tmJXGMTLwr6?= =?us-ascii?Q?wm4dym1yrG9NSX/yhOz7NbYvpBm+CT+w2tZTL+Gj/BlFO/FPLtzjxYzBfB1E?= =?us-ascii?Q?y0SGWPk5JftdX8OOvAzo=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0701MB1718; 5:5U7vQTFdkG5nCvFQMysHY3g7T1N/qGfUXcjwU6Bd6b9N0I0JY9qBuqVHsFtjStTD6O7EilZzUu8+mxPBTg7iXmKiPfzJo6GCC4A/SyYzQJwQB2M1IRkfb3AX+y7DcZ5msLSBQDR2GQbxFZPu1OrUbA==; 24:kmBdwOh5ieql1KFHbZb6oGM0DhI2OqD8/E891bcZfd8Lgo5s5HFS1vgVrcCK6H1xPOTHLvx+XGmKqJOmQ58hMrx6agrIO+CEQHhh+qv/9ec= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2016 17:34:13.1896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0701MB1718 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] Patch introducing API to read/write Intel Architecture Model Specific Registers (MSR), rte_msr_read and rte_msr_write functions. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jan 2016 17:34:17 -0000 On Wed, Jan 06, 2016 at 11:47:28AM +0000, Andralojc, WojciechX wrote: > > From: Andralojc, WojciechX > > Sent: Thursday, December 17, 2015 12:13 PM > > To: dev@dpdk.org > > Cc: Andralojc, WojciechX > > Subject: [PATCH] Patch introducing API to read/write Intel Architecture Model > > Specific Registers (MSR), rte_msr_read and rte_msr_write functions. > > > > There is work in progress to implement Intel Cache Allocation Technology (CAT) > > support in DPDK, this technology is programmed through MSRs. > > In the future it will be possible to program CAT through Linux cgroups and DPDK > > CAT implementation will take advantage of it. > > > > MSR R/W's are privileged ring 0 operations and they must be done in kernel > > space. For this reason implementation utilizes Linux MSR driver. > > > > Signed-off-by: Wojciech Andralojc > > I've got suggestion offline that as MSRs are IA specific, > I should not give the dummy APIs for the other arches > and move MSR access functions into the EAL specific APIs > or some place more arch specific. > Do you find submitted MSR patch OK? > or do you agree with the above feedback and patch should be re-worked? +1 IMO, No need to expose this function as EAL as other archs can't implement this.I think, a IA specific function under lib/librte_eal/common/include/arch/x86/ and removing rte_* from internal architecture functions looks more appropriate Jerin > I am looking forward to your feedback > > Thank you! > > Wojciech Andralojc > -------------------------------------------------------------- > Intel Research and Development Ireland Limited > Registered in Ireland > Registered Office: Collinstown Industrial Park, Leixlip, County Kildare > Registered Number: 308263 > > > This e-mail and any attachments may contain confidential material for the sole > use of the intended recipient(s). Any review or distribution by others is > strictly prohibited. If you are not the intended recipient, please contact the > sender and delete all copies. >