From: Stephen Hemminger <stephen@networkplumber.org>
To: Santosh Shukla <sshukla@mvista.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 03/12] linuxapp: eal: arm: Always return 0 for rte_eal_iopl_init()
Date: Thu, 7 Jan 2016 10:14:07 -0800 [thread overview]
Message-ID: <20160107101407.54b18175@xeon-e3> (raw)
In-Reply-To: <1452184390-5994-4-git-send-email-sshukla@mvista.com>
On Thu, 7 Jan 2016 22:03:00 +0530
Santosh Shukla <sshukla@mvista.com> wrote:
> #else
> +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
> + return 0; /* iopl syscall not supported for ARM/ARM64 */
> +#endif
> return -1;
> #endif
Minor net why not:
#elif defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
return -1
#else
That way you won't generate two return statements and potentially
trigger warnings from static checkers.
next prev parent reply other threads:[~2016-01-07 18:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 16:32 [dpdk-dev] [PATCH v3 00/12] Add virtio support for arm/arm64 Santosh Shukla
2016-01-07 16:32 ` [dpdk-dev] [PATCH v3 01/12] virtio: Introduce config RTE_VIRTIO_INC_VECTOR Santosh Shukla
2016-01-07 16:32 ` [dpdk-dev] [PATCH v3 02/12] config: i686: set RTE_VIRTIO_INC_VECTOR=n Santosh Shukla
2016-01-07 16:33 ` [dpdk-dev] [PATCH v3 03/12] linuxapp: eal: arm: Always return 0 for rte_eal_iopl_init() Santosh Shukla
2016-01-07 18:14 ` Stephen Hemminger [this message]
2016-01-09 13:18 ` Santosh Shukla
2016-01-07 16:33 ` [dpdk-dev] [PATCH v3 04/12] linuxapp/vfio: ignore mapping for ioport region Santosh Shukla
2016-01-07 18:16 ` Stephen Hemminger
2016-01-07 18:53 ` Santosh Shukla
2016-01-08 7:29 ` Yuanhan Liu
2016-01-07 16:33 ` [dpdk-dev] [PATCH v3 05/12] virtio_pci.h: build fix for sys/io.h for non-x86 arch Santosh Shukla
2016-01-07 16:33 ` [dpdk-dev] [PATCH v3 06/12] eal: pci: vfio: add rd/wr func for pci bar space Santosh Shukla
2016-01-07 18:19 ` Stephen Hemminger
2016-01-07 18:26 ` Wiles, Keith
2016-01-07 18:39 ` Stephen Hemminger
2016-01-07 18:48 ` Santosh Shukla
2016-01-07 18:46 ` Santosh Shukla
2016-01-13 14:47 ` Bruce Richardson
2016-01-07 16:33 ` [dpdk-dev] [PATCH v3 07/12] virtio: vfio: add api support to rd/wr ioport bar Santosh Shukla
2016-01-07 16:33 ` [dpdk-dev] [PATCH v3 08/12] virtio: Add capability to initialize driver for vfio interface Santosh Shukla
2016-01-07 16:33 ` [dpdk-dev] [PATCH v3 09/12] virtio: vfio: Enable RTE_PCI_DRV_NEED_MAPPING flag in driver Santosh Shukla
2016-01-07 18:20 ` Stephen Hemminger
2016-01-09 12:38 ` Santosh Shukla
2016-01-12 7:14 ` Yuanhan Liu
2016-01-13 12:18 ` Santosh Shukla
2016-01-07 16:33 ` [dpdk-dev] [PATCH v3 10/12] config: armv7/v8: Enable RTE_LIBRTE_VIRTIO_PMD Santosh Shukla
2016-01-07 16:33 ` [dpdk-dev] [PATCH v3 11/12] vfio: Support for no-IOMMU mode Santosh Shukla
2016-01-07 16:33 ` [dpdk-dev] [PATCH v3 12/12] eal: pci: vfio: fix build error Santosh Shukla
2016-01-07 17:02 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107101407.54b18175@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=sshukla@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).