From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com
 [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 72536B3D6
 for <dev@dpdk.org>; Thu,  7 Jan 2016 19:14:00 +0100 (CET)
Received: by mail-pa0-f51.google.com with SMTP id ho8so3612248pac.2
 for <dev@dpdk.org>; Thu, 07 Jan 2016 10:14:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding;
 bh=8nhaiYF/6TFatwONA3wY0kYUr8b+RKMZBdMpwd1rcZ0=;
 b=YkofcRo7xlKGsAx2xIQGKOc3tFzkZtf8lpeOq59gjFEe7e42C5T3Cbtqj2MA8j+2x2
 iB/i5opo8VsvXTYJXwaLv9uAk/5aibabYUkonkN6UhVgwNJ2gm8ygZWTxdSVZBs0q7sd
 wuhLfZ5Gj04d14XIFWH2q+uGBfNTKaW5B8TfxAyUHqM0aLiNybFZXs5wh8QkNktiEzNg
 pEnLxwkTU90PVHMZwp6Qrn+LQcz/uBbZIGo+eqjq3vhfng0Be6dJKsRdsLf3kdSG1O9o
 h56dtEeSNgDuu984i/eXtxBweegZqVOquzYkybiYwaQk+jIN1e1xjpzbogOxxuwi+mMw
 9Icw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=8nhaiYF/6TFatwONA3wY0kYUr8b+RKMZBdMpwd1rcZ0=;
 b=bBnm1FAuvAi2UCZhRjMJOdX6LcRhUAn4buL+euOGfSpNQejgoh6Rgqi9sIn+XKxRgl
 FDP04VLvXplFoHo4avkfUzQ5MJfSSo0Sga/kf9io3GhVv9daDouBOQUD1vnXZoHC4XC3
 /orK7KpNowdKXchQg/AHB1FBPYTTZN+ryNnRiQdBl0Pm3xIngoHpYzGN1N4vZ94L88C0
 hIxq10NUfYEyoNx8mUBaBhcdDuvmMA9Z2WMujeddMIfqsVGiZmg1czAo0X34U8wqqgit
 Jgtw56k6YbnAg2pRsraajHdhMMKPZT1FIsgVZxPWzJ5CSB/gx0S+2DcgJD8RPTC+bK8J
 niqg==
X-Gm-Message-State: ALoCoQlKr7Q5z0CBElxHSpCA27OP+R+swx3/W0ojBMyjffnckD9gwmDDEhz6gVIhF4GmrNRgFRNufpiruTwaIz+PPVkU7B0HMw==
X-Received: by 10.66.250.165 with SMTP id zd5mr79629842pac.9.1452190439678;
 Thu, 07 Jan 2016 10:13:59 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id tm4sm160473029pab.3.2016.01.07.10.13.59
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 07 Jan 2016 10:13:59 -0800 (PST)
Date: Thu, 7 Jan 2016 10:14:07 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Santosh Shukla <sshukla@mvista.com>
Message-ID: <20160107101407.54b18175@xeon-e3>
In-Reply-To: <1452184390-5994-4-git-send-email-sshukla@mvista.com>
References: <1452184390-5994-1-git-send-email-sshukla@mvista.com>
 <1452184390-5994-4-git-send-email-sshukla@mvista.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 03/12] linuxapp: eal: arm: Always return 0
 for rte_eal_iopl_init()
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jan 2016 18:14:00 -0000

On Thu,  7 Jan 2016 22:03:00 +0530
Santosh Shukla <sshukla@mvista.com> wrote:

>  #else
> +#if defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
> +	return 0; /* iopl syscall not supported for ARM/ARM64 */
> +#endif
>  	return -1;
>  #endif

Minor net why not:

#elif defined(RTE_ARCH_ARM) || defined(RTE_ARCH_ARM64)
	return -1
#else

That way you won't generate two return statements and potentially
trigger warnings from static checkers.