From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id 446BB9224 for ; Thu, 7 Jan 2016 19:20:52 +0100 (CET) Received: by mail-pa0-f44.google.com with SMTP id ho8so3745807pac.2 for ; Thu, 07 Jan 2016 10:20:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=ABUym0GdwU77htg6fnTw2VN4gZSBjfCDb1f1YznbrO0=; b=kSw8HAykcb8LMELz0/cd7neTWa309QShqhRiLZ47PM8TF77Kp6AVRyYIL2kSTP+iHk RF/NwdFmsWkN94UnB0smpzEsw/xtM4cx36xhE990WimWBLejwHV4BFq2SwLUkWdyGqlw LG/mtYvs0Vl1hHfgKRkiVQquuaGex5f6dpucOCAHqguBK/AoDzEGke3Bbpf0MQWUBDi6 q9AludlikmLQ0LvnuJQgzKGj3A5XxRy7OJOK5U8hII4kOxLng21d7RGHdkk+oQw5rAWw 2FP9RPP84XJuN9TonFaVW1GRck/9U8lSnoSREM5OKiaAlRkx7qwpyCR54ml6tjUvpTnJ uF1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=ABUym0GdwU77htg6fnTw2VN4gZSBjfCDb1f1YznbrO0=; b=JoGc+v51ldVCGKqmf6Ja76aDZ6lMgdYsDz6nmw8JvrWm9LYdtcY87enyHH9Vqnj9sf b/vmskzO1fuvOO6ciCKry8dVoEhjQYQQR8qzIUmQYvbEqixM1N7iqvsU5FvR8H+Ckr5n eLyos7wAhtjoGGegW/133tjG7j4pGiGdcOlnCOKKhDvcISPqjtNTrFwrmiH9gt/w8R2B 30Uq5JgYd2A6gerlrV0yll+cLoB6zcuE1JAdkXPhDPTb+KBecA4U+CFoR/DhFstA4e2M nAqvtd6Os2Q88D6KfI3HDQWCddLeAPjuJZm5808/TamgL1oFutK/KEcHjcJWMRMFvoeB OYjw== X-Gm-Message-State: ALoCoQn8Bx6RtlkyD3LUoDI6pljGngAtYzPbUFpkL/V910w13WMbGDMcKFMDmAYKg27U0tFMcGQEP/GrShCs7owemdUrGNEGRA== X-Received: by 10.66.216.200 with SMTP id os8mr153781359pac.143.1452190851602; Thu, 07 Jan 2016 10:20:51 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id rt6sm160675877pab.17.2016.01.07.10.20.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jan 2016 10:20:51 -0800 (PST) Date: Thu, 7 Jan 2016 10:20:58 -0800 From: Stephen Hemminger To: Santosh Shukla Message-ID: <20160107102058.43499eae@xeon-e3> In-Reply-To: <1452184390-5994-10-git-send-email-sshukla@mvista.com> References: <1452184390-5994-1-git-send-email-sshukla@mvista.com> <1452184390-5994-10-git-send-email-sshukla@mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 09/12] virtio: vfio: Enable RTE_PCI_DRV_NEED_MAPPING flag in driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jan 2016 18:20:52 -0000 On Thu, 7 Jan 2016 22:03:06 +0530 Santosh Shukla wrote: > +#ifdef RTE_EAL_VFIO > + .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_DETACHABLE, > +#else > .drv_flags = RTE_PCI_DRV_DETACHABLE, > +#endif Since VFIO is determined at runtime not compile time, the flags should be updated at runtime not compile time.