From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id CD0419A92
 for <dev@dpdk.org>; Fri,  8 Jan 2016 08:29:13 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by fmsmga104.fm.intel.com with ESMTP; 07 Jan 2016 23:29:12 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,537,1444719600"; d="scan'208";a="856214527"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49])
 by orsmga001.jf.intel.com with ESMTP; 07 Jan 2016 23:29:11 -0800
Date: Fri, 8 Jan 2016 15:29:27 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Santosh Shukla <sshukla@mvista.com>
Message-ID: <20160108072927.GK26062@yliu-dev.sh.intel.com>
References: <1452184390-5994-1-git-send-email-sshukla@mvista.com>
 <1452184390-5994-5-git-send-email-sshukla@mvista.com>
 <20160107101649.3a0384d2@xeon-e3>
 <CAAyOgsYqkLYELH=6CDDaJWdcZqtnSzWBrvh5xc8sFOZJ=-UgvA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAAyOgsYqkLYELH=6CDDaJWdcZqtnSzWBrvh5xc8sFOZJ=-UgvA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 04/12] linuxapp/vfio: ignore mapping for
	ioport region
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jan 2016 07:29:14 -0000

On Fri, Jan 08, 2016 at 12:23:15AM +0530, Santosh Shukla wrote:
> 
> 
> On Thu, Jan 7, 2016 at 11:46 PM, Stephen Hemminger <stephen@networkplumber.org>
> wrote:
>  
> 
>     > +             ret = pread64(vfio_dev_fd, &ioport_bar, sizeof(ioport_bar),
>     > +                           VFIO_GET_REGION_ADDR
>     (VFIO_PCI_CONFIG_REGION_INDEX)
>     > +                           + PCI_BASE_ADDRESS_0 + i*4);
>     > +
>     > +             if (ret != sizeof(ioport_bar)) {
>     > +                     RTE_LOG(ERR, EAL,
>     > +                             "Cannot read command (%x) from PCI config"
>     > +                             "space!\n", PCI_BASE_ADDRESS_0 + i*4);
> 
>     Please dont split the line of a log message string in mid sentence.
>    

First of all, it'd be good if you can fix your email client to reply
emails in a way open source world prefer, such as prefixing last email
with leading '> ', and do not auto fold lines.

> me to don't like splitting, This was deliberate to keep checkpatch happy, If we
> are ok with debug message > 80 line warning I guess  it will improve code
> readability.

You may try to shorten your message to "Cannot read cmd %x from config
space!" :)

> 
> 
>     > +                     return -1;
>     > +             }
>     > +
>     > +             if (ioport_bar & PCI_BASE_ADDRESS_SPACE_IO) {
>     > +                     RTE_LOG(INFO, EAL, "\tIgnore mapping since Its a i/
>     o"
>     > +                                        "port bar (%d) addr : %x\n", i,
>     same here
> 
> 
> Agreed.

Ditto, maybe following is better

    "Ignore mapping IO port bar %d, addr: %x\n".

	--yliu