From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com
 [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id B97415A24
 for <dev@dpdk.org>; Sun, 10 Jan 2016 21:02:01 +0100 (CET)
Received: by mail-pa0-f42.google.com with SMTP id yy13so217817535pab.3
 for <dev@dpdk.org>; Sun, 10 Jan 2016 12:02:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding;
 bh=6YZqOUgL5qroBKsGjlrHEGjret09a+64/BSkqpvdThE=;
 b=nOGH8YfJNVUiKxv97aQPn10KRTN5R0GLsY25KLP95TC5DODA5+8+1QPUG3Mm5h0zNV
 AyMzz/+k19daI1OHhuzso9uhVP/UB9wJoLu+g+/b2qXo1XNhY2IUhdGpJChSImUlFQM6
 Cxt183qEtmKDI+lr5zL/4SnnLd3XzE/ElmciFkZjMuautWuQG/Yzkr2DRT2VdzpsdjD/
 j66cHkdiwu9HBoylaVQ3J+OKKBiZyNxAvAX9Kp2xqM8A87iZ62gkgVUJ5KIrOVNPh7Y4
 Ia5CUa77yQ04Q4FoDzkL0JQCqI6LeVpYUQP5u2Aa/Cz0zBud67dx0IlfXUEr6cvK+snB
 DNGQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-type:content-transfer-encoding;
 bh=6YZqOUgL5qroBKsGjlrHEGjret09a+64/BSkqpvdThE=;
 b=hM4FusofNwouvDOUGjr8Fkz807f0pR4nU9Yl0HCDVitO8KOUSLj4eqjM2Rjt0zGbsC
 OB0bK4d8M2bOto6V58SAWgqzCPo49uIi2Q70BTEd2ZJXPRmP71wDdxGs/270LTfhmz29
 5GmqfqjoLvPpDBfNFgpPzhVFeGTrMB4Z8gmBv2aHnD3ry+XUYWTk2oUly6+bwymHx0zf
 1yWmXYykZzEuBRS6Db01MtnA7JFIjGXo4rRjStGmiKZLO0Ve0GD8wKJWMbVaFH+NiM9S
 zmSDktsCOxDYLyncrV99tl9pOBUu6l+nUpAFe2YP71rOunNHl2W7pGC+KbBEHPlwGZBx
 yrFg==
X-Gm-Message-State: ALoCoQkSN9cLG8TpzuQmcbETE5bq0AUO446048B6hQ+TcqfVEPtVMkZVnW2HXdPOkh4Sp4puSZTinW1CYgZUu3rM+hCOdFKacA==
X-Received: by 10.66.156.106 with SMTP id wd10mr175982097pab.150.1452456120860; 
 Sun, 10 Jan 2016 12:02:00 -0800 (PST)
Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net.
 [50.53.82.155])
 by smtp.gmail.com with ESMTPSA id o4sm18156393pfa.85.2016.01.10.12.02.00
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 10 Jan 2016 12:02:00 -0800 (PST)
Date: Sun, 10 Jan 2016 12:02:08 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@6wind.com>
Message-ID: <20160110120208.702d22c5@xeon-e3>
In-Reply-To: <1452430254-30390-4-git-send-email-david.marchand@6wind.com>
References: <CALwxeUt49PB2TKy_V-9GoQYdDHP3GeBb5LK6jBxdLEYVnRY-vw@mail.gmail.com>
 <1452430254-30390-1-git-send-email-david.marchand@6wind.com>
 <1452430254-30390-4-git-send-email-david.marchand@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, thomas.monjalon@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 03/11] i40e: move pci device ids to driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 10 Jan 2016 20:02:02 -0000

On Sun, 10 Jan 2016 13:50:46 +0100
David Marchand <david.marchand@6wind.com> wrote:

> +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_SFP_XL710) },
> +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_QEMU) },
> +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_KX_A) },
> +{ RTE_PCI_DEVICE(I40E_INTEL_VENDOR_ID, I40E_DEV_ID_KX_B) }

You should indent the initializers.