From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 8A6A15686 for ; Wed, 13 Jan 2016 05:56:32 +0100 (CET) Received: by mail-pa0-f42.google.com with SMTP id yy13so259010200pab.3 for ; Tue, 12 Jan 2016 20:56:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=ZmEGkLsL6HgWJeM6oyTlcKGdtg6mdE8DFbsNrQPJ/7M=; b=KUSIBsWbXgi7PDOkoewuYpRyG/nU4Yb+jskzFUpAOHC6HhKuQAy5LzE6J6827xdL6w 4R+snI80vBn/grvrONuXsJQYvz5JPAqP8N39HTGbVDIR05AeM+ug4o4vxqRZF39+5Ng+ z9d9ZOG3Q7NoHg6DUhQKyMJXpfnR1A/+BbqO9bTRTJLiI073xgL+ykd4qtB1nTlnAM8z xQdiDpeefy37MDsZ5uUCIumPZrlqrdQmMcHf4AeShj5odYBwQrH7DpY9+e+u8qQuW1Ct y05qgS8gofnbK/e6acp2A54MdBRFtwsr9oJohdgrVKVLPsG3k3N+sZb9++TNfwcAoLOu kW5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=ZmEGkLsL6HgWJeM6oyTlcKGdtg6mdE8DFbsNrQPJ/7M=; b=WLHhHh8yBmuuhJYTknaF543juV8g74iEVrcc5xCVns6W0FwZQpP0+zyScpFcWAMH1O tfoWG5J6fO5j8sx2Z0GWtlqJj1rWaXDZp35YIhpXJf5lGVAaYOrrFV+6YQCB+ngxOPB3 RRZLlN0+phiay98EHwVAhAwkq1lr7KEao5uKqr5v9hma/zoZ2qSnZSmmS2M/mbocsMRT pYIl0ecEqqiUKJUEqiwxcZmTySIlO5eI2zHJFdreMUWqiNncod6G267Q8gp/fXZGZuQC zZSx5pEwPhn0AVjJ9Vmrn/7A1oD7zJDACCnaSIvDX9DaRUubmukccCla+SVMqC95frd5 gM5A== X-Gm-Message-State: ALoCoQnVCOCKqtx4j4fHBn27Wu8ZfV9ufOvOu/HCey5PT6h0na89hzIgz072YgvzI16GPrlVw1sA+GlOIZcyQ7qJ/v90gJ3prw== X-Received: by 10.66.63.104 with SMTP id f8mr27452779pas.41.1452660991959; Tue, 12 Jan 2016 20:56:31 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id o81sm17832466pfi.92.2016.01.12.20.56.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jan 2016 20:56:31 -0800 (PST) Date: Tue, 12 Jan 2016 20:56:34 -0800 From: Stephen Hemminger To: Yong Wang Message-ID: <20160112205634.7bd2d50d@xeon-e3> In-Reply-To: <1452650917-7960-1-git-send-email-yongwang@vmware.com> References: <1452650917-7960-1-git-send-email-yongwang@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 0/6] vmxnet3 TSO, tx cksum offload and cleanups X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 04:56:33 -0000 On Tue, 12 Jan 2016 18:08:31 -0800 Yong Wang wrote: > v4: > * moved cleanups to separate patches > * correctly handled multi-seg pkts with data ring used > > v3: > * fixed comments from Stephen > * added performance number for tx data ring > > v2: > * fixed some logging issues when debug option turned on > * updated the txq_flags check in vmxnet3_dev_tx_queue_setup() > > This patchset adds TCP/UDP checksum offload and TSO to vmxnet3 PMD. > One of the use cases is to support STT. It also restores the tx > data ring feature that was removed from a previous patch. > > Yong Wang (6): > vmxnet3: fix typos and remove unused struct > vmxnet3: restore tx data ring support > vmxnet3: cleanup txNumDeferred usage > vmxnet3: add tx l4 cksum offload > vmxnet3: add TSO support > vmxnet3: announce device offload capability > > doc/guides/rel_notes/release_2_3.rst | 11 +++ > drivers/net/vmxnet3/base/includeCheck.h | 39 -------- > drivers/net/vmxnet3/base/vmxnet3_defs.h | 9 +- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 16 +++- > drivers/net/vmxnet3/vmxnet3_ring.h | 13 --- > drivers/net/vmxnet3/vmxnet3_rxtx.c | 160 +++++++++++++++++++++++++------- > 6 files changed, 151 insertions(+), 97 deletions(-) > delete mode 100644 drivers/net/vmxnet3/base/includeCheck.h > Looks good. The only thing maybe worth adding would be some more checks int the vmxnet3_dev_configure for unsupported offload bits, etc. Acked-by: Stephen Hemminger