From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3739BF72 for ; Wed, 13 Jan 2016 02:37:07 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 12 Jan 2016 17:37:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,286,1449561600"; d="scan'208";a="725839140" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga003.jf.intel.com with ESMTP; 12 Jan 2016 17:37:05 -0800 Date: Wed, 13 Jan 2016 09:38:10 +0800 From: Yuanhan Liu To: Pavel Fedin Message-ID: <20160113013810.GD19531@yliu-dev.sh.intel.com> References: <1452609306-7724-1-git-send-email-p.fedin@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452609306-7724-1-git-send-email-p.fedin@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vhost_user: Make sure that memory map is set before attempting address translation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 01:37:07 -0000 On Tue, Jan 12, 2016 at 05:35:06PM +0300, Pavel Fedin wrote: > Malfunctioning virtio clients may not send VHOST_USER_SET_MEM_TABLE for > some reason. This causes NULL dereference in qva_to_vva(). > > Change-Id: Ibc8f6637fb5fb9885b02c316adf18afd45e0d49a What's this? An internal track id? If so, you should not include it here: it's just meaningless to us. Otherwise, this patch looks good to me. --yliu