[dpdk-dev] [PATCH] vhost_user: Make sure that memory map is set before attempting address translation

[dpdk-dev] [PATCH] vhost_user: Make sure that memory map is set before attempting address translation

[Pavel Fedin]

Malfunctioning virtio clients may not send VHOST_USER_SET_MEM_TABLE for
some reason. This causes NULL dereference in qva_to_vva().

Change-Id: Ibc8f6637fb5fb9885b02c316adf18afd45e0d49a
Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
---
 lib/librte_vhost/virtio-net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_vhost/virtio-net.c b/lib/librte_vhost/virtio-net.c
index 0ba5045..3e7cec0 100644
--- a/lib/librte_vhost/virtio-net.c
+++ b/lib/librte_vhost/virtio-net.c
@@ -630,7 +630,7 @@ set_vring_addr(struct vhost_device_ctx ctx, struct vhost_vring_addr *addr)
 	struct vhost_virtqueue *vq;
 
 	dev = get_device(ctx);
-	if (dev == NULL)
+	if ((dev == NULL) || (dev->mem == NULL))
 		return -1;
 
 	/* addr->index refers to the queue index. The txq 1, rxq is 0. */
-- 
2.1.1

Re: [dpdk-dev] [PATCH] vhost_user: Make sure that memory map is set before attempting address translation

[Yuanhan Liu]

On Tue, Jan 12, 2016 at 05:35:06PM +0300, Pavel Fedin wrote:
> Malfunctioning virtio clients may not send VHOST_USER_SET_MEM_TABLE for
> some reason. This causes NULL dereference in qva_to_vva().
> 
> Change-Id: Ibc8f6637fb5fb9885b02c316adf18afd45e0d49a

What's this? An internal track id? If so, you should not include it
here: it's just meaningless to us.

Otherwise, this patch looks good to me.

	--yliu

Re: [dpdk-dev] [PATCH] vhost_user: Make sure that memory map is set before attempting address translation

[Pavel Fedin]

 Hello!

> > Change-Id: Ibc8f6637fb5fb9885b02c316adf18afd45e0d49a
> 
> What's this? An internal track id?

 Yes, it's from our gerrit. I've just done git format-patch.

> If so, you should not include it
> here: it's just meaningless to us.
> 
> Otherwise, this patch looks good to me.

 Should i repost, or can you just drop this tag by yourself when applying?

Kind regards,
Pavel Fedin
Senior Engineer
Samsung Electronics Research center Russia

Re: [dpdk-dev] [PATCH] vhost_user: Make sure that memory map is set before attempting address translation

[Yuanhan Liu]

On Wed, Jan 13, 2016 at 10:18:43AM +0300, Pavel Fedin wrote:
>  Hello!
> 
> > > Change-Id: Ibc8f6637fb5fb9885b02c316adf18afd45e0d49a
> > 
> > What's this? An internal track id?
> 
>  Yes, it's from our gerrit. I've just done git format-patch.
> 
> > If so, you should not include it
> > here: it's just meaningless to us.
> > 
> > Otherwise, this patch looks good to me.
> 
>  Should i repost, or can you just drop this tag by yourself when applying?

I'd suggest so. Since it's Thomas (but not me) to apply your patch.
And if you repost, you can add my ACK:

Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>

	--yliu