From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4D1188DAD for ; Wed, 13 Jan 2016 12:55:09 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 13 Jan 2016 03:55:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,288,1449561600"; d="scan'208";a="28568477" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.64]) by fmsmga004.fm.intel.com with SMTP; 13 Jan 2016 03:55:04 -0800 Received: by (sSMTP sendmail emulation); Wed, 13 Jan 2016 11:55:03 +0025 Date: Wed, 13 Jan 2016 11:55:03 +0000 From: Bruce Richardson To: Stephen Hemminger Message-ID: <20160113115503.GC7216@bricha3-MOBL3> References: <1451357606-117892-1-git-send-email-ziye.yang@intel.com> <20151231091214.0acd9d4e@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151231091214.0acd9d4e@xeon-e3> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Ziye Yang , dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] pci: Add the class_id support in pci probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 11:55:09 -0000 On Thu, Dec 31, 2015 at 09:12:14AM -0800, Stephen Hemminger wrote: > On Tue, 29 Dec 2015 10:53:26 +0800 > Ziye Yang wrote: > > > This patch is used to add the class_id support > > for pci_probe since some devices need the class_info > > (class_code, subclass_code, programming_interface) > > > > Signed-off-by: Ziye Yang > > Since rte_pci is exposed to application this breaks the ABI. But applications are not going to be defining rte_pci_ids values internally, are they? That is for drivers to use. Is this really an ABI breakage for applications that we need to be concerned about? /Bruce