From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so1.wedos.net (wes1-so1.wedos.net [46.28.106.15]) by dpdk.org (Postfix) with ESMTP id 9FD218E69 for ; Wed, 13 Jan 2016 15:14:28 +0100 (CET) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so1.wedos.net (Postfix) with ESMTPSA id 3pgW441Syvz4xk; Wed, 13 Jan 2016 15:14:28 +0100 (CET) Date: Wed, 13 Jan 2016 15:12:27 +0100 From: Jan Viktorin To: Bruce Richardson Message-ID: <20160113151227.6cfcd0a9@pcviktorin.fit.vutbr.cz> In-Reply-To: <20160113140118.GA16036@bricha3-MOBL3> References: <1451938106-12145-1-git-send-email-viktorin@rehivetech.com> <1451938106-12145-4-git-send-email-viktorin@rehivetech.com> <20160113140118.GA16036@bricha3-MOBL3> Organization: RehiveTech MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 03/14] eal/common: introduce union rte_device and related X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 14:14:28 -0000 On Wed, 13 Jan 2016 14:01:19 +0000 Bruce Richardson wrote: > On Mon, Jan 04, 2016 at 09:08:15PM +0100, Jan Viktorin wrote: > > The union rte_device can be used in situations where we want to work with all > > devices without distinguishing among bus-specific features (PCI, ...). > > The target device type can be detected by reading the magic. > > > > Also, the macros RTE_DEVICE_DECL and RTE_DEVICE_PTR_DECL are introduced to > > provide a generic way to declare a device or a pointer to a device. The macros > > aim to preserve API backwards-compatibility. Eg. > > > > struct old_super_struct { => struct old_super_struct { > > struct rte_pci_device *pci_dev; => RTE_DEVICE_PTR_DECL(pci_dev); > > ... => ... > > }; => }; > > > > struct old_super_struct inst; > > > > The new code should reference inst.dev.pci, the old code can still use the > > inst.pci_dev. The previously introduced magic is included so one can ask the > > instance about its type: > > > > if (inst.dev.magic == RTE_PCI_DEVICE_MAGIC) { > > ... > > } > > Rather than magic numbers i.e. #defines, an enum might be better. True. However, would it be helpful to put really some _magic_ numbers there for debugging purposes (to clearly recognize the data type)? Or, is it sufficient to just say 1 for PCI, 2 for SoC, 3 for xxx...? > > /Bruce > -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic