From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id B95B48DB3 for ; Fri, 15 Jan 2016 09:44:58 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id l65so11097571wmf.1 for ; Fri, 15 Jan 2016 00:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=mcEfen09ipLLDQRSJxV/UmkRyKBJj3Wyx/dEOTmumTE=; b=m8Euh3+BzdEOLM7K8mdkGUxMB7mo17jC5ywRqKi2CcQmSSmJQfTARgFa+SGcjvczh/ 7bA9zl3rC6vag9HUL2OG+cClOr/m1qn5KdBsVgqgCSZQdFCa1vQOhJaYvtHTLe3UGR3x kogPxZ4Bxlz1C923w2SIY0TcY0HFfRtEY2EqABzef+18yGX9BME0iOObyXso2U6VCh+t y6ZeEhs5+FNIcpAaXHaXU9Cof5wlpjUnXfE6HtKxHfL4ESLYN9BiOPB3YjMjoktefZGE gD6Ev4TaitDlnBUb/G2H1Ad8Ye23jl3l508iz5JANMqB9JYCaRDA5oxlRql4YeGV7XFa rCUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=mcEfen09ipLLDQRSJxV/UmkRyKBJj3Wyx/dEOTmumTE=; b=CRImujdclSEvDb+4WJJGkfc9Y+zCaxpEMj/gnzs4GqGk3ciMao3pzItJykB90/u9D2 7H4/Ufgte/v4CwM+QNgQTNrKKwtq6F3/ANt50hFKsT/XBMarWCLM25kADGNxMMEgyKM2 xRAASJn0Bb+jthYmd4Rosu4y4bkusFHCtVS2htqoQjlwSKiunk7MJA8Fy6zmJPc0FpCE tL0ZXd2+3aS+KMeCI+Z+cjpemh/fPqZpolgdsXgJ8iNFR9RGDDpWkthnepW74X4g+z/4 BRALqBUiOecaXu9k5kup057rQAf2E2/j9qRT3/flC9uLHJVZ1zJaOhcP6OCV4wv2fMWL poEg== X-Gm-Message-State: AG10YOS61H3huiFwFjcUGrDkjAdqG45tp9n1tKJt7mid0ZwyvPhnRZCWr0IK5SZ4ApgWKQke X-Received: by 10.28.54.78 with SMTP id d75mr2076279wma.6.1452847498504; Fri, 15 Jan 2016 00:44:58 -0800 (PST) Received: from autoinstall.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id w23sm1531611wmd.1.2016.01.15.00.44.56 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 15 Jan 2016 00:44:57 -0800 (PST) Date: Fri, 15 Jan 2016 09:44:39 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Panu Matilainen , john.mcnamara@intel.com Message-ID: <20160115084439.GW13678@autoinstall.dev.6wind.com> References: <1452090774-10650-1-git-send-email-nelio.laranjeiro@6wind.com> <1452595749-11297-1-git-send-email-nelio.laranjeiro@6wind.com> <1452595749-11297-2-git-send-email-nelio.laranjeiro@6wind.com> <5694F58F.1040105@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5694F58F.1040105@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/3] cmdline: increase command line buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jan 2016 08:44:58 -0000 On Tue, Jan 12, 2016 at 02:46:07PM +0200, Panu Matilainen wrote: > On 01/12/2016 12:49 PM, Nelio Laranjeiro wrote: > >Allow long command lines in testpmd (like flow director with IPv6, ...). > > > >Signed-off-by: John McNamara > >Signed-off-by: Nelio Laranjeiro > >--- > > doc/guides/rel_notes/deprecation.rst | 5 ----- > > lib/librte_cmdline/cmdline_rdline.h | 2 +- > > 2 files changed, 1 insertion(+), 6 deletions(-) > > > >diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > >index e94d4a2..9cb288c 100644 > >--- a/doc/guides/rel_notes/deprecation.rst > >+++ b/doc/guides/rel_notes/deprecation.rst > >@@ -44,8 +44,3 @@ Deprecation Notices > > and table action handlers will be updated: > > the pipeline parameter will be added, the packets mask parameter will be > > either removed (for input port action handler) or made input-only. > >- > >-* ABI changes are planned in cmdline buffer size to allow the use of long > >- commands (such as RETA update in testpmd). This should impact > >- CMDLINE_PARSE_RESULT_BUFSIZE, STR_TOKEN_SIZE and RDLINE_BUF_SIZE. > >- It should be integrated in release 2.3. > >diff --git a/lib/librte_cmdline/cmdline_rdline.h b/lib/librte_cmdline/cmdline_rdline.h > >index b9aad9b..72e2dad 100644 > >--- a/lib/librte_cmdline/cmdline_rdline.h > >+++ b/lib/librte_cmdline/cmdline_rdline.h > >@@ -93,7 +93,7 @@ extern "C" { > > #endif > > > > /* configuration */ > >-#define RDLINE_BUF_SIZE 256 > >+#define RDLINE_BUF_SIZE 512 > > #define RDLINE_PROMPT_SIZE 32 > > #define RDLINE_VT100_BUF_SIZE 8 > > #define RDLINE_HISTORY_BUF_SIZE BUFSIZ > > Having to break a library ABI for a change like this is a bit ridiculous. Sure, but John McNamara needed it to handle flow director with IPv6[1]. For my part, I was needing it to manipulate the RETA table, but as I wrote in the cover letter, it ends by breaking other commands. Olivier Matz, has proposed another way to handle long commands lines[2], it could be a good idea to go on this direction. For RETA situation, we already discussed on a new API, but for now, I do not have time for it (and as it is another ABI breakage it could only be done for 16.07 or 2.4)[3]. If this patch is no more needed we can just drop it, for that I would like to have the point of view from John. > > I didn't try it so could be wrong, but based on a quick look, struct rdline > could easily be made opaque to consumers by just adding functions for > allocating and freeing it. > > - Panu - > [1] http://dpdk.org/ml/archives/dev/2015-November/027643.html [2] http://dpdk.org/ml/archives/dev/2015-November/028557.html [3] http://dpdk.org/ml/archives/dev/2015-October/025294.html -- Nélio Laranjeiro 6WIND