From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f169.google.com (mail-pf0-f169.google.com [209.85.192.169]) by dpdk.org (Postfix) with ESMTP id 5010F8E95 for ; Thu, 21 Jan 2016 20:00:08 +0100 (CET) Received: by mail-pf0-f169.google.com with SMTP id n128so27821512pfn.3 for ; Thu, 21 Jan 2016 11:00:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=ZM5ovyXh2gKNH01toBqHuA/NxadBO1BdWPDIgKTw6i0=; b=iyhUzUutmX0HFXd7IaINTSYk5e1WLOH02sARiPfJ2lOcmoBSijchRpHIREJFo10m8N bZ2qJoEChKHwkbcZTPEE1h+/KqLUK2ohrvoDmD2Bp+Vlu++w+qQ0Bi+tg55R6GFAgX3Z /k7O1T/7hWyvrhMGvVwqana/LjkO7FHDIC9iiljUd4hbX8snwuVMe2uaHoy9VBpVyyNs kKF4IGXdFsa4vVn/xImklEJJzdGcg8vIEmRfRgtQWz24XA3hueRV3qC0aRLOux27VJkU QoxEoEGzr2k4J6PrCvhm+5zEyaZ8dtbs1oZRej9CwqNfBaKqEfx1yVReh1igy9g9geQh EETA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=ZM5ovyXh2gKNH01toBqHuA/NxadBO1BdWPDIgKTw6i0=; b=QmqxA3nAL3fNj1zObIkEKCgrdlObbnZZ3rpHB6zwPeR9hvya4WXIjjVpFQTgdra4Di X47ysZHRMitJX3fGqDde+vuYzc+Cvm1+piJggAALQB1b2GxHgsEOFffopxqpdSB7g9nh /ytuOj9LvN6Qxl/iZQsyfjYhfdbG3Wn4+mh2CDgOBoL207GbZDHHxzzkKDTfgg7gxGy0 kQtVPHWWRCjBb+9G+h1YB1+CToQe0uOSVYc3MMEv51kP5m4zTFZJG1xTQx7innWoXDRO GbWAfajjDk17CT4myg4BPPDRKWkk3NykE84KAAB2Ge/H+1lHlQg7eVrQJi2FxrA1MJxn ZIZw== X-Gm-Message-State: ALoCoQnO8X9IvAkwLwkeU5A/9dmftYsbA+zzcy8xTv4N1bnLsDYsnShtIkWkLSt+XHHQ461EKU1KCslWzLIjjaVZDi1mEGGVmA== X-Received: by 10.98.93.84 with SMTP id r81mr63285390pfb.64.1453402807423; Thu, 21 Jan 2016 11:00:07 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id p66sm4308533pfi.34.2016.01.21.11.00.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Jan 2016 11:00:07 -0800 (PST) Date: Thu, 21 Jan 2016 11:00:14 -0800 From: Stephen Hemminger To: "Wiles, Keith" Message-ID: <20160121110014.760613fb@xeon-e3> In-Reply-To: <2E473283-0D93-4E33-9D50-7067AC1E9285@intel.com> References: <569F2A07.9000606@mhcomputing.net> <56A09AE8.8050308@redhat.com> <2E473283-0D93-4E33-9D50-7067AC1E9285@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PKTGEN] fixing weird termio issues that complicate debugging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2016 19:00:08 -0000 On Thu, 21 Jan 2016 15:03:37 +0000 "Wiles, Keith" wrote: > On 1/21/16, 2:46 AM, "Panu Matilainen" wrote: > > >On 01/20/2016 06:26 PM, Wiles, Keith wrote: > >> On 1/20/16, 12:32 AM, "dev on behalf of Matthew Hall" wrote: > >> > >>> Hello, > >>> > >>> Since the pktgen code is reindented I am finding time to read through it > >>> and experiment and see if I can get it working. > >>> > >>> I have issues with the init process of pktgen. It is difficult to debug > >>> it because the init code does a lot of very scary stuff to the terminal > >>> control / TTY device at inconvenient times in an inconvenient order, and > >>> in the process damages the debug output and damages the screen of your > >>> GDB without doing weird things to run GDB on a different TTY. > >>> > >>> Of course I am willing to contribute patches and not just complain, but > >>> first I need some help to follow what is going on. > >>> > >>> Here is the problematic call-flow with some explanation what went wrong > >>> trying it on some community machines outside of its original environment: > >>> > >>> 1) it calls printf("\n%s %s\n", wr_copyright_msg(), wr_powered_by()); > >>> which dumps tons of weird boilerplate of licenses, copyrights, code > >>> creator, etc. > >>> > >>> It is open source and everybody that matters already knows who coded it, > >>> so is this stuff really that important? This gets in the way when you > >>> are trying to work on it and I just have to comment it out. > >> > >> One problem is a number of people wanted to steal the code and use in > >> a paid application, so the copyright is some what a requirement. > > > >In that case, why is it under a BSD'ish license instead of something > >like GPL that's designed to prevent it in the first place? Might be too > >late to change it by now, just wondering. > > DPDK is BSD, so you can not use a GPL application with DPDK (I think) anyway I can try to speed you the screens, but does it really matter as these are only at startup and I normally leave pktgen running for long periods of time. The extra time at the start does not seem to be a big issue, right? > > > > >> As you may know I do a lot of debugging on Pktgen and I feel they are > >> a nuisance. I can try to see if we can clean up these messages, but > >> do not hold your breath on getting them to be removed. > > > >It would make a world of difference if it just printed the copyright etc > >in a couple of lines during startup, instead of taking over the entire > >screen for several seconds. > > > >This is a whole lot like those anti-piracy ad campaigns on DVDs which > >you cant skip, so all the *legitimate* users are forced to suffer > >through them but all the bad guys just rip it out of their copies. DRM > >that ends up hurting the legitimate users the most is never a good idea. > > > > - Panu - > > > > > > > > > Regards, > Keith I would rip out the whole tty control and theming nonsense and then just print one line copyright on startup.