From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wes1-so2.wedos.net (wes1-so2.wedos.net [46.28.106.16]) by dpdk.org (Postfix) with ESMTP id 572039247 for ; Tue, 26 Jan 2016 16:48:35 +0100 (CET) Received: from pcviktorin.fit.vutbr.cz (pcviktorin.fit.vutbr.cz [147.229.13.147]) by wes1-so2.wedos.net (Postfix) with ESMTPSA id 3pqXXg0V7Czv8; Tue, 26 Jan 2016 16:48:35 +0100 (CET) Date: Tue, 26 Jan 2016 16:50:26 +0100 From: "Jan Viktorin" To: David Marchand Message-ID: <20160126165026.21738001@pcviktorin.fit.vutbr.cz> In-Reply-To: <1453471618-29722-2-git-send-email-david.marchand@6wind.com> References: <1453377431-25850-1-git-send-email-david.marchand@6wind.com> <1453471618-29722-1-git-send-email-david.marchand@6wind.com> <1453471618-29722-2-git-send-email-david.marchand@6wind.com> Organization: RehiveTech MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: remove useless null checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jan 2016 15:48:35 -0000 What about the RTE_VERIFY? I think, it's more appropriate here. Otherwise, feel free to add: Reviewed-by: Jan Viktorin On Fri, 22 Jan 2016 15:06:57 +0100 David Marchand wrote: > We are in static functions and those passed arguments can't be NULL. > > Signed-off-by: David Marchand > --- > lib/librte_ether/rte_ethdev.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index ed971b4..cab74e0 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -220,9 +220,6 @@ rte_eth_dev_create_unique_device_name(char *name, size_t size, > { > int ret; > > - if ((name == NULL) || (pci_dev == NULL)) > - return -EINVAL; > - > ret = snprintf(name, size, "%d:%d.%d", > pci_dev->addr.bus, pci_dev->addr.devid, > pci_dev->addr.function); > @@ -505,9 +502,6 @@ rte_eth_dev_is_detachable(uint8_t port_id) > static int > rte_eth_dev_attach_pdev(struct rte_pci_addr *addr, uint8_t *port_id) > { > - if ((addr == NULL) || (port_id == NULL)) > - goto err; > - > /* re-construct pci_device_list */ > if (rte_eal_pci_scan()) > goto err; > @@ -531,9 +525,6 @@ rte_eth_dev_detach_pdev(uint8_t port_id, struct rte_pci_addr *addr) > struct rte_pci_addr freed_addr; > struct rte_pci_addr vp; > > - if (addr == NULL) > - goto err; > - > /* check whether the driver supports detach feature, or not */ > if (rte_eth_dev_is_detachable(port_id)) > goto err; > @@ -566,9 +557,6 @@ rte_eth_dev_attach_vdev(const char *vdevargs, uint8_t *port_id) > char *name = NULL, *args = NULL; > int ret = -1; > > - if ((vdevargs == NULL) || (port_id == NULL)) > - goto end; > - > /* parse vdevargs, then retrieve device name and args */ > if (rte_eal_parse_devargs_str(vdevargs, &name, &args)) > goto end; > @@ -602,9 +590,6 @@ rte_eth_dev_detach_vdev(uint8_t port_id, char *vdevname) > { > char name[RTE_ETH_NAME_MAX_LEN]; > > - if (vdevname == NULL) > - goto err; > - > /* check whether the driver supports detach feature, or not */ > if (rte_eth_dev_is_detachable(port_id)) > goto err; -- Jan Viktorin E-mail: Viktorin@RehiveTech.com System Architect Web: www.RehiveTech.com RehiveTech Brno, Czech Republic