From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 029B7938C
 for <dev@dpdk.org>; Tue, 26 Jan 2016 21:16:35 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP; 26 Jan 2016 12:16:35 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,351,1449561600"; d="scan'208";a="641803808"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.34.202.20])
 by FMSMGA003.fm.intel.com with SMTP; 26 Jan 2016 12:16:32 -0800
Received: by  (sSMTP sendmail emulation); Tue, 26 Jan 2016 12:16:32 -0700
Date: Tue, 26 Jan 2016 12:16:32 -0800
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>
Message-ID: <20160126201631.GA10276@bricha3-MOBL3>
References: <1453372561-11431-1-git-send-email-xiao.w.wang@intel.com>
 <1453372561-11431-16-git-send-email-xiao.w.wang@intel.com>
 <20160122213137.GA19964@bricha3-MOBL3>
 <B7F2E978279D1D49A3034B7786DACF403DB91AE0@SHSMSX101.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <B7F2E978279D1D49A3034B7786DACF403DB91AE0@SHSMSX101.ccr.corp.intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 15/16] fm10k: use default mailbox message
 handler for pf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jan 2016 20:16:36 -0000

On Mon, Jan 25, 2016 at 02:31:05AM +0000, Wang, Xiao W wrote:
> Hi Bruce,
> 
> > -----Original Message-----
> > From: Richardson, Bruce
> > Sent: Saturday, January 23, 2016 5:32 AM
> > To: Wang, Xiao W <xiao.w.wang@intel.com>
> > Cc: Chen, Jing D <jing.d.chen@intel.com>; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 15/16] fm10k: use default mailbox message
> > handler for pf
> > 
> > On Thu, Jan 21, 2016 at 06:36:00PM +0800, Wang Xiao W wrote:
> > > The new share code makes fm10k_msg_update_pvid_pf function static, so
> > > we can not refer to it now in fm10k_ethdev.c. The registered pf
> > > handler is almost the same as the default pf handler, removing it has no
> > impact on mailbox.
> > >
> > > Signed-off-by: Wang Xiao W <xiao.w.wang@intel.com>
> > 
> > What patch makes the function static, as we need to ensure that the build is
> > not broken by having this patch in the wrong place in the patchset?
> > 
> > Also, it seems strange having this patch in the middle of a series of base code
> > updates - perhaps it should go first, so that all base code update patches can
> > go one after the other.
> > 
> > /Bruce
> 
> It's the first patch in the patch set that makes the function static.

So does this patch not need to go before patch 1, if we can't refer to the function
once patch one is applied?

/Bruce