From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 287EBC46E for ; Thu, 28 Jan 2016 14:15:03 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 28 Jan 2016 05:15:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,358,1449561600"; d="scan'208";a="642842002" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by FMSMGA003.fm.intel.com with ESMTP; 28 Jan 2016 05:15:01 -0800 Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com [10.237.217.37]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id u0SDF0jr030898; Thu, 28 Jan 2016 13:15:00 GMT Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1]) by sivlogin002.ir.intel.com with ESMTP id u0SDF0xH018042; Thu, 28 Jan 2016 13:15:00 GMT Received: (from fyigit@localhost) by sivlogin002.ir.intel.com with œ id u0SDF0qa018038; Thu, 28 Jan 2016 13:15:00 GMT X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to ferruh.yigit@intel.com using -f Date: Thu, 28 Jan 2016 13:15:00 +0000 From: Ferruh Yigit To: Remy Horton Message-ID: <20160128131500.GA16492@sivlogin002.ir.intel.com> Mail-Followup-To: Remy Horton , dev@dpdk.org References: <1453911849-16562-1-git-send-email-ferruh.yigit@intel.com> <1453911849-16562-3-git-send-email-ferruh.yigit@intel.com> <56A9F827.1060403@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56A9F827.1060403@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 2/3] rte_ctrl_if: add control interface library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 13:15:03 -0000 On Thu, Jan 28, 2016 at 11:14:47AM +0000, Remy Horton wrote: > On 27/01/2016 16:24, Ferruh Yigit wrote: > > > + default: > > + ret = -95 /* EOPNOTSUPP */; > > + break; > > Is this intentional? -EOPNOTSUPP is -122 (-95 is -ENOTSOCK).. > Return value is not significant, callee just checks for negative value, I can remove comment to prevent confusion. Thanks, ferruh