From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7D0CAC47E for ; Thu, 28 Jan 2016 15:23:50 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga101.jf.intel.com with ESMTP; 28 Jan 2016 06:22:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,358,1449561600"; d="scan'208";a="37809146" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga004.fm.intel.com with ESMTP; 28 Jan 2016 06:22:05 -0800 Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com [10.237.217.37]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id u0SEM4M6020489; Thu, 28 Jan 2016 14:22:04 GMT Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1]) by sivlogin002.ir.intel.com with ESMTP id u0SEM43T002569; Thu, 28 Jan 2016 14:22:04 GMT Received: (from fyigit@localhost) by sivlogin002.ir.intel.com with œ id u0SEM4V1002565; Thu, 28 Jan 2016 14:22:04 GMT X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to ferruh.yigit@intel.com using -f Date: Thu, 28 Jan 2016 14:22:04 +0000 From: "Yigit, Ferruh" To: "Ananyev, Konstantin" Message-ID: <20160128142204.GA880@sivlogin002.ir.intel.com> Mail-Followup-To: "Ananyev, Konstantin" , "Horton, Remy" , "dev@dpdk.org" References: <1453911849-16562-1-git-send-email-ferruh.yigit@intel.com> <1453911849-16562-3-git-send-email-ferruh.yigit@intel.com> <56A9F827.1060403@intel.com> <20160128131500.GA16492@sivlogin002.ir.intel.com> <2601191342CEEE43887BDE71AB97725836AFFCC8@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2601191342CEEE43887BDE71AB97725836AFFCC8@irsmsx105.ger.corp.intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/3] rte_ctrl_if: add control interface library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 14:23:50 -0000 On Thu, Jan 28, 2016 at 01:57:04PM +0000, Ananyev, Konstantin wrote: > Hi Ferruh, > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit > > Sent: Thursday, January 28, 2016 1:15 PM > > To: Horton, Remy > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 2/3] rte_ctrl_if: add control interface library > > > > On Thu, Jan 28, 2016 at 11:14:47AM +0000, Remy Horton wrote: > > > On 27/01/2016 16:24, Ferruh Yigit wrote: > > > > > > > + default: > > > > + ret = -95 /* EOPNOTSUPP */; > > > > + break; > > > > > > Is this intentional? -EOPNOTSUPP is -122 (-95 is -ENOTSOCK).. > > > > > Return value is not significant, callee just checks for negative value, > > I can remove comment to prevent confusion. > > Please use values defined in errno.h, there are plenty of them, > no need to invent your own error codes. OK > Also pls don't forget to address all comments I gave you offline. Yes, I also remember your comment when I saw this J, it seems this one missed. I will address in next revision. Thanks, ferruh