From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1E7B58E56 for ; Tue, 2 Feb 2016 06:17:45 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 01 Feb 2016 21:17:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,383,1449561600"; d="scan'208";a="645586459" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by FMSMGA003.fm.intel.com with ESMTP; 01 Feb 2016 21:17:43 -0800 Date: Tue, 2 Feb 2016 13:19:12 +0800 From: Yuanhan Liu To: Santosh Shukla Message-ID: <20160202051912.GH4257@yliu-dev.sh.intel.com> References: <1454091717-32251-1-git-send-email-sshukla@mvista.com> <1454091717-32251-6-git-send-email-sshukla@mvista.com> <20160201124845.GC4257@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, Rakesh Krishnamurthy , Rizwan Ansari Subject: Re: [dpdk-dev] [PATCH v6 6/8] virtio: add vfio api to rd/wr ioport space X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2016 05:17:46 -0000 On Tue, Feb 02, 2016 at 10:00:36AM +0530, Santosh Shukla wrote: > > > > BTW, I didn't follow the noIOMMU discussion; how did it end? Do we still > > need that? Is this patch a full story to enable virtio on ARM? > > > Ok, We agreed that explicit __noiommu suffix not required, atleast for > rte_xx_drv struct{}, as because sooner than later we'll have virtio > working for both flavours ie... iommu/noiommu. My only worry was > parsing for _noiommu and default vfio case, as because noiomu needed > user to preset "enable_noiommu_" param for vfio driver to do mode > switch. But we wont need that parsing as because if param is not set > then binding won't happen, which Thomas rightly pointed out, therefore > I choose to drop resource parsing for virtio-for-vfio case, now virtio > driver to check only drv->kdrv == RTE_KDRV_VFIO so to make sure > interface attached to vfio or not. > > But perhaps when we have both flavours working for virtio, then we > should at least prompt a INFO message on console that virtio pmd > driver attached to default vfio or noIOMMU. > > So we don't need explicit _noIOMMU. Thanks for the explanation. > > Yes this patch is to enable non-x86 arch to use virtio pmd driver > (virtio 0.95 spec). After this patch merges-in, I am planning to > - replace sys/io.h entirely Hmm, be more specific? Replace it with what? > - Add raw_read/raw_writel() api for arm/arm64 {Already proposed > similar implementation in v2} so that they could use virtio 1.0spec > mapped memory, for both UIO/VFIO mode. PCI memory bar mapping works both with UIO/VFIO on ARM, without any extra efforts, right? If so, it should just work with my patch set and yours. --yliu