From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f176.google.com (mail-pf0-f176.google.com [209.85.192.176]) by dpdk.org (Postfix) with ESMTP id 109D32E81 for ; Thu, 4 Feb 2016 01:53:29 +0100 (CET) Received: by mail-pf0-f176.google.com with SMTP id o185so24617519pfb.1 for ; Wed, 03 Feb 2016 16:53:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=T7tRFTlRMFJDQuFhb0Phpmzm2JwheJhaK9CX4uOtJus=; b=q9IEKKZiQJG6M2vWQd5FBrl138d/Br4aHE3Jgh3hUXIs2KzdAo/cMhSuNWhpFn7X9s xeidBRugvCL4xIcIpwzeLQLEUUtcHbyYVPzpgnXS5q43BtuxHWK0Xpv3WkYxLewq8oHI V7TGozHmP4fiAfrBKsHvTRCtVd9Xa2PPN8M61veFLIZZqCIfdvirDI6v44Bf2dq5eooH ePcD7xaAyFGGGurZTGpKsBlcLbHiProqVpdMeTxuOqFq0wdwTiETTXWhS/2sFZd2YZJH efS3k5MlqJUUF1GBdQ1Dli894fLgFxfo6NahIWyL0OBv0kctR6v+ooBV8Byl/qFQg/EI wCow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=T7tRFTlRMFJDQuFhb0Phpmzm2JwheJhaK9CX4uOtJus=; b=mkHmwfTZ0GPQoH9VqEE40pl0xBIVYqYyKW6nTYglWTgvikRUZmq3uXd8ETgjJE4q7C K1D8dqcI56MQnDAsZ+sHJSQ0TUwLHFGD3vGxWSaFVjrU0HX6IA4rzUYL2VGXwej/fQ9t 7E6ADsOuU+YxQJD8o84ErjIQVZyCK3dnjyqxQjRaDRPwEbypyBTT7xEhAMSw7FnaKZRE WtRc8uNkAijrPE/IlH/PFndJ2vS35aDmZeoBYEilKN/y6HszUnRL+fUa3ehl438NgFpL gWWHUZpIr5XNXnPhAxtNzVH8sRzTcpNb5FcI/gyaoDLKMNP1zPnBYjWV+A6x2KAAZAMq HSZA== X-Gm-Message-State: AG10YORmbMkzc3hgm8oATJ9C/cXmCQ0rpTErCTecyg/NUl5KlCqXdDZisl55Cx3ES0ZdZg== X-Received: by 10.98.70.211 with SMTP id o80mr6862694pfi.124.1454547208492; Wed, 03 Feb 2016 16:53:28 -0800 (PST) Received: from samsung9 ([138.44.251.21]) by smtp.gmail.com with ESMTPSA id fl9sm12415938pab.30.2016.02.03.16.53.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Feb 2016 16:53:28 -0800 (PST) Date: Thu, 4 Feb 2016 11:53:20 +1100 From: Stephen Hemminger To: "Zhang, Helin" Message-ID: <20160204115320.1d50bde8@samsung9> In-Reply-To: References: <1453137515-19195-1-git-send-email-julien.meunier@6wind.com> <1454421057-6602-1-git-send-email-julien.meunier@6wind.com> <56B1E54A.3000900@6wind.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "dev@dpdk.org" , Julien Meunier Subject: Re: [dpdk-dev] [PATCH v2] i40e: fix vlan filtering X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Feb 2016 00:53:29 -0000 On Thu, 4 Feb 2016 00:41:00 +0000 "Zhang, Helin" wrote: > > -----Original Message----- > > From: Julien Meunier [mailto:julien.meunier@6wind.com] > > Sent: Wednesday, February 3, 2016 7:32 PM > > To: Zhang, Helin > > Cc: dev@dpdk.org > > Subject: Re: [PATCH v2] i40e: fix vlan filtering > > > > Hello, > > > > INFO log level is used in order to keep code homogeneity: > > i40e_vsi_config_vlan_stripping or i40e_dev_init_vlan use this log level during > > failure for example. > > > > Tell me if ERR log level for VLAN filtering issue must be set. > There is a failure, and may result in uncertain behaviors which cannot be ignored. > I'd suggest to use ERR but not INFO, though I am not so confident on that. > Could Thomas help give some guidance on that? Sounds like NOTICE level.