From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <yuanhan.liu@linux.intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id 886BD688E
for <dev@dpdk.org>; Sat, 6 Feb 2016 05:55:19 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
by fmsmga103.fm.intel.com with ESMTP; 05 Feb 2016 20:55:20 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,404,1449561600"; d="scan'208";a="906690617"
Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49])
by orsmga002.jf.intel.com with ESMTP; 05 Feb 2016 20:55:17 -0800
Date: Sat, 6 Feb 2016 12:57:29 +0800
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Tetsuya Mukawa <mukawa@igel.co.jp>
Message-ID: <20160206045729.GH22958@yliu-dev.sh.intel.com>
References: <1454570791-19131-3-git-send-email-mukawa@igel.co.jp>
<1454671693-3886-2-git-send-email-mukawa@igel.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1454671693-3886-2-git-send-email-mukawa@igel.co.jp>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org, ann.zhuangyanying@huawei.com
Subject: Re: [dpdk-dev] [PATCH v8 1/2] ethdev: Add a new event type to
notify a queue state changed event
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Feb 2016 04:55:19 -0000
On Fri, Feb 05, 2016 at 08:28:12PM +0900, Tetsuya Mukawa wrote:
> This patch adds a below event type.
> - RTE_ETH_EVENT_QUEUE_STATE_CHANGE
> This event is used for notifying a queue state changed event.
>
> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> lib/librte_ether/rte_ethdev.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 8710dd7..2fbf42a 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -2661,6 +2661,8 @@ rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id,
> enum rte_eth_event_type {
> RTE_ETH_EVENT_UNKNOWN, /**< unknown event type */
> RTE_ETH_EVENT_INTR_LSC, /**< lsc interrupt event */
> + RTE_ETH_EVENT_QUEUE_STATE_CHANGE,
> + /**< queue state changed interrupt */
Though it's defined to be a generic event, you might need to note in
the comment that vhost-pmd is the only user so far.
Anyway, it looks good to me:
Reviewed-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
--yliu