From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0055.outbound.protection.outlook.com [207.46.100.55]) by dpdk.org (Postfix) with ESMTP id B9CC0559C for ; Mon, 8 Feb 2016 10:08:01 +0100 (CET) Authentication-Results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (122.167.181.96) by BY1PR0701MB1721.namprd07.prod.outlook.com (10.162.111.140) with Microsoft SMTP Server (TLS) id 15.1.403.16; Mon, 8 Feb 2016 09:07:57 +0000 Date: Mon, 8 Feb 2016 14:37:38 +0530 From: Jerin Jacob To: Thomas Monjalon Message-ID: <20160208090737.GC10260@localhost.localdomain> References: <1449498170-19872-1-git-send-email-jerin.jacob@caviumnetworks.com> <1750446.FDPWrLgo55@xps13> <20151208093333.GA3650@localhost.localdomain> <20160129042455.GA24789@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160129042455.GA24789@localhost.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [122.167.181.96] X-ClientProxiedBy: MA1PR01CA0068.INDPRD01.PROD.OUTLOOK.COM (25.164.116.168) To BY1PR0701MB1721.namprd07.prod.outlook.com (25.162.111.140) X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 2:EMzds9n9BjhArWQ6LpjXd4IRQRyE7fmX5ZjNcAtY/fVlTyNBJhejTBHih0H+2M0pe6bEs2a909wAEyv3mRGf5D6nQZodMoCI5zXykCb4eDwjvlojquV6g2zcjRf8U3gMCFLZpitt9REhAwlRVTXS4Q==; 3:3ClzA4FrP3mlTxhDjKpW/BDTn55ccFSHQ0ISd8x2h4u2gc8aKMGoulp9ZZPNUO9acqcx+ML0+Y7l3wSED7dn91oxuLpPumgsdCqpt+w58jE4kGnDSvylLf7ZerkZsKv0; 25:qbhGg0NDCeUHP++nUXJYlfPWWLIygqfrRGvqw0Ygk2Gu3xaDrUtUnlfNUHaRUErg/oriykynuxKq+1VLx0YqOkGgvV84haSgqJFEb9uFKWpTg78r9P/Dh5JMzRcM4F5cU66zrF+CqVZcJisKAMtOaM3MWgyvouBP3/joKC6VgMUudYBvUxZ4x1FPIFw5rUs5n+0BZN/c63Se1SUKzPVMywuNm28tMy3W9hxBPB01wCe+qPzz0FUNp5CoUPinu+yiK3O6BqM21eXCz+QZyDluvRcOlUTt6gdJkpvhjc91+8Ja69vlgrS/po9LrBTVYs6K X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0701MB1721; X-MS-Office365-Filtering-Correlation-Id: 117bb949-77f7-4cdd-dfd9-08d3306757a4 X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 20:1dYSO04YvQE5xX1qxpaou75Jp8oammIvRVHqDf1s+FHkqhtiT+l6f93hJrnRZ6nfkwEpHq1kkzZC/dmkP5MFjK7ms869Le/N8ZOmRFgIucALh2a7LlHDqJlGjMk4yLgVHdz3LCdYmjs3eMdz6Z+MY6m3zatnxJp+0Jj78VEReQmwSuTui7MGeXe1be+ZNqkAS6Rq8UYywwGvv8v8aTn2RjkAf0RLudpjfDCuBPwC3K+H1qc1X2gdbPa64mRKdD32++kImcCYFc9F3YSs3cgmzvrdJytNsOSlh1wacbN2Ue0hteYDyF1OyDrwdC7rZMnlyM2fUpcnl1ccqvB8mk6pCi+xaznM+WxqiN+MJnax3iNyx4BU+xmrqjuXgRNvD6NG1StnMAee05RK10BQ70T1BmOL2SBjCNAx691eIB4L3apgUyUjtzJAElSVgdV027CcLb27bYAzYRI5bqMw0bXey9JikbfOngxf4O3Mz50iwwB9qqAgsp0bw7wngHVou3BWUAgSWc78Ua95ge4olXZNZZQoG19anrsVhq58yxNw2jC8NUEWHRtNkfgeBcOcyZpGEedRoXutT0OtOybj6Q9HGX53aPY/GxwqEp826kX2Sn4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:BY1PR0701MB1721; BCL:0; PCL:0; RULEID:; SRVR:BY1PR0701MB1721; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 4:R2qepj2oS3/GN68O5ipS9cgMJTcwhj0ElZpBh0/OOho9yAzerF8IWreW8I59IK0NeSe0tj884xzfUVWT4HQhrGPiNwEL/7r+8+W7g1CfX+PRadmPT6FauK4jU7FeKZEZUpQMkDdoPxGpkpddDvQH/nZjgFZFsaxSjBrSRTG82KueuKsq7RO8DKIW7da/LDWwJYqxhSE7DPEjzUADh1znw9VdGv25KIFir+ZZjcI4EgB2B4WgvlnOUAMVIgKrqgJ4Nm6rtzgEi4ly19dFZYTRPzOyrSw61mhSjz1hiI5ep6p90+ZwCTr0eNBj2puCHcuis0t/Bc8SLhEIjm8yOKJtvGEPqWtRWnhHUyS/CGKGnxN2MPrM+85q55M3AdoZVImM X-Forefront-PRVS: 084674B2CF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6069001)(6009001)(377424004)(24454002)(2950100001)(66066001)(586003)(4001350100001)(6116002)(3846002)(23726003)(47776003)(5008740100001)(77096005)(1096002)(1076002)(50986999)(54356999)(76176999)(97756001)(42186005)(61506002)(40100003)(122386002)(5004730100002)(50466002)(83506001)(93886004)(19580395003)(33656002)(19580405001)(189998001)(92566002)(86362001)(87976001)(4326007)(46406003)(5001960100002)(2906002)(110136002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1721; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1721; 23:963BrVsPmT1ndpFYXCi9eZPSS+XVTmRy1diPEsc?= =?us-ascii?Q?xlWuyhI8qmlWBZl474m8DpTDU6KkxUUphg3dljV0/3fi2mFV0q5f3zSzNFFR?= =?us-ascii?Q?uR8LxS9PXxVRgAQkzSMA2cpn/fJedSUJ/D9o+FyDZ2/Ph4cqmRfgBpMDT4Ng?= =?us-ascii?Q?UO0WZJdmiyf5GmNaEg01mUe9lvhEfWoi6Abf1jJ3FOSL/v8e9C3VKo2gCXo5?= =?us-ascii?Q?JCocTi6XrEGvIE5jVGfNlY2FpiJ/V85dUkUzdZdPrV1tvEWYbrEpCgJEbhU7?= =?us-ascii?Q?98KA+BR0whn0TxTRWv57Skvz9rnYSnE9FwLtguyIPFyFbTy7apvB8B5+nKwU?= =?us-ascii?Q?5QIn80QFM2YRxapeyBO7IX5j9xI8eL72/HTz0VAlRMQEZs63pgVfxiCVSWbc?= =?us-ascii?Q?7vmmAjHWrPoKh0n9bkvRUzGGLukkKOR2Xon6IEP1IhzMf5Yr29/2nvo4Muyl?= =?us-ascii?Q?A4ELfbKY2x9xH6M55eSipMm4neVazaVhPVcm2Uf3AwUgVT575As8pxG6NyhC?= =?us-ascii?Q?SgvdIYnrXvwYsGIKH5p6QRW6IErUTuFSFcywAChOEOSa/qBSfxXiz3FAg1e0?= =?us-ascii?Q?8lGLBOy5EZ//U9vrpdIUkt30UhlAJouNxSgMqsZ3dIb/JZgreWzMfnUFQ6N7?= =?us-ascii?Q?Scyqsqr5HV/JGU+MpV5VPHiBGvUD6SEeGWz1Q71Is07ZpRiU1GokAmjbGpFU?= =?us-ascii?Q?Q21kJ/WkaLQ0bPhvzyqY08JJuCF+nzpBNTJmkJOqq0jMvC8hUXdDoV5mCMda?= =?us-ascii?Q?RIZvaHyBm0K1BTocBcOrWHbY5gbr6JPxE8UYC0wsQaGQQa7q7JBzktslnY1k?= =?us-ascii?Q?l/NABOVLWLkRfeIsSjYaxV1gUduHUAcK8W9CUr7ORmAX6CcAD8y2ZG5Qkd2T?= =?us-ascii?Q?4GPGwU0JfGnaYEPSWcToXygi7ToqFKzjcMTrjXvSgVlYKUAa8EVCaleapDBJ?= =?us-ascii?Q?3F3trODn4AADzVsCewdBKAA2y/2avq8USxgWysAvydk3iEcDWOKlGXigdNXS?= =?us-ascii?Q?PZa9rUv18kzLZCpFKO31dpZCN8qAlcLFS/CFn9I+cp0B5Y6hI1Rn7YDSTBPh?= =?us-ascii?Q?bhHACccpqsTPyQ5qbXzgkN/j1qeXN?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1721; 5:x4iCBA2CCP+D5d9KShWTD0nwnqF7heRDcqp13QsFCoqhtKLBLRzcQEB8mrc4bZ6NPiuQH/njfQ2NTfiitUIFO3c4i2/P71PR9Q6RIolx6tieeSml0ZTXsLp5U0UzWRegVGfVVruD+XAM6NvD7nx44w==; 24:qLP0v5XmVkYl060rVO7AyURpSXlmlgx6H0oQFuN86RNIA1PWFzwWQDdM6ZLIDoH3DPSNPOpTkbW08nKjM7Lh4e0ZBK2eDg+cxgVkHCl4fFk= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2016 09:07:57.6433 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1721 Cc: dev@dpdk.org, viktorin@rehivetech.com Subject: Re: [dpdk-dev] [PATCH] config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2016 09:08:02 -0000 On Fri, Jan 29, 2016 at 09:54:55AM +0530, Jerin Jacob wrote: > On Tue, Dec 08, 2015 at 03:03:34PM +0530, Jerin Jacob wrote: > > On Mon, Dec 07, 2015 at 03:45:10PM +0100, Thomas Monjalon wrote: > > > 2015-12-07 19:52, Jerin Jacob: > > > > by default, all the targets will be configured with the 64-byte cache line > > > > size, targets which have different cache line size can be overridden > > > > through target specific config file. > > > > > > > > Selected ThunderX and power8 as CONFIG_RTE_CACHE_LINE_SIZE=128 targets > > > > based on existing configuration. > > > > > > > > Signed-off-by: Jerin Jacob > > > > > > It looks good. > > > We are moving from a constant defined on CC command line in most cases > > > to a constant included in rte_config.h only. > > > Have you checked that the generated libraries are identical? > > > > Yes, Tested with a 64byte(x86_64-native-linuxapp-gcc) and a 128byte > > (arm64-thunderx-linuxapp-gcc) target. > > md5sum build/app/test comes same with or without patch. > > ping Thomas, Can you review this, This is a long pending item. This rework based on your request. Jerin > > > > > > It would be good to have a check for POWER8. Chao? > > > Thanks