DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 0/4] fix performance/cache resource issues with 128-byte cache line targets
Date: Mon, 8 Feb 2016 16:22:17 +0530	[thread overview]
Message-ID: <20160208105216.GA14217@localhost.localdomain> (raw)
In-Reply-To: <20160208112430.4cbc543a@jvn>

On Mon, Feb 08, 2016 at 11:24:30AM +0100, Jan Viktorin wrote:
> Hello Jerin,
>
> I failed to apply the v4 series. I've tried multiple bases. The v3
> applied successfully to v2.2.0-rc4. Could you give the proper working
> base?

Hello Jan,

Please apply the depended "config: cleanup existing RTE_CACHE_LINE_SIZE
selection scheme" patch first as mentioned in the cover letter.

http://dpdk.org/dev/patchwork/patch/9388/

>
> Applying patch #10232 using 'git am'
> Description: [dpdk-dev,v4,2/4] mbuf: fix performance/cache resource issue with 128-byte cache line targets
> Applying: mbuf: fix performance/cache resource issue with 128-byte cache line targets
> error: patch failed: lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h:68
> error: lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h: patch does not apply
> Patch failed at 0001 mbuf: fix performance/cache resource issue with 128-byte cache line targets
> The copy of the patch that failed is found in: /home/jviki/upstream/dpdk/.git/worktrees/dpdk-pw/rebase-apply/patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> 'git am' failed with exit status 128
> Try to fix git-am manually or exit...
>
> Regards
> Jan
>
> On Mon, 8 Feb 2016 15:01:58 +0530
> Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote:
>
> > On Fri, Jan 29, 2016 at 01:15:51PM +0530, Jerin Jacob wrote:
> > > This patchset fixes performance/cache resource issues with 128-byte cache line targets
> > > found in mbuf and bitmap DPDK libraries
> > >
> > > Currently, we have two DPDK targets(ThunderX and ppc_64) which are based on
> > > 128-bytes cache line size target.
> > >
> > > This patchset doesn't introduce any performance degradation
> > > for 64-bytes cache line size targets.
> > >
> > > v1..v2
> > > - Introduced new cache macro definitions as Suggested by Konstantin
> > > - Reduced the cache alignment requirement for 128-byte cache targets in
> > > slow-path data structures to save the memory
> > > - Verified x86(a 64byte cacheline target) does not have any impact on these changes by
> > > verifying the md5sum of app/test,app/testpmd, app/testacl binaries with
> > > or without this patch set
> > >
> > > v2..v3
> > >
> > > revert the cache alignment of rte_ring_debug_stats,
> > > rte_mempool_debug_stats structures
> > >
> > > v3..v4
> > > replaced RTE_CACHE_MIN_LINE_SIZE with RTE_CACHE_LINE_MIN_SIZE as suggested by
> > > olivier.matz@6wind.com
> > >
> > > For clean git am, "config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme"
> > > patch needs to apply first
> > >
> > > Jerin Jacob (4):
> > >   eal: Introduce new cache line macro definitions
> > >   mbuf: fix performance/cache resource issue with 128-byte cache line
> > >     targets
> > >   bitmap: optimize for 128-bytes cache line targets
> > >   cache/slow-path: reduce cache align requirement for 128-byte cache
> > >     targets
> > >
> >
> > ping for review/merge
> >
> > >  app/test/test_mbuf.c                                     |  2 +-
> > >  lib/librte_eal/common/include/rte_memory.h               | 16 ++++++++++++++++
> > >  .../linuxapp/eal/include/exec-env/rte_kni_common.h       |  4 +++-
> > >  lib/librte_ether/rte_ethdev.h                            |  4 ++--
> > >  lib/librte_mbuf/rte_mbuf.h                               |  2 +-
> > >  lib/librte_sched/rte_bitmap.h                            | 10 +++++-----
> > >  6 files changed, 28 insertions(+), 10 deletions(-)
> > >
> > > --
> > > 2.1.0
> > >
>
>
>
> --
>   Jan Viktorin                E-mail: Viktorin@RehiveTech.com
>   System Architect            Web:    www.RehiveTech.com
>   RehiveTech
>   Brno, Czech Republic

  reply	other threads:[~2016-02-08 10:52 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-06 15:59 [dpdk-dev] [PATCH 0/2] " Jerin Jacob
2015-12-06 15:59 ` [dpdk-dev] [PATCH 1/2] mbuf: fix performance/cache resource issue " Jerin Jacob
2015-12-07 15:21   ` Ananyev, Konstantin
2015-12-08 12:45     ` Jerin Jacob
2015-12-08 16:07       ` Ananyev, Konstantin
2015-12-08 17:49         ` Jerin Jacob
2015-12-09 13:44           ` Ananyev, Konstantin
2015-12-09 14:49             ` Jerin Jacob
2015-12-06 15:59 ` [dpdk-dev] [PATCH 2/2] bitmap: optimize for 128-bytes " Jerin Jacob
2015-12-06 16:30 ` [dpdk-dev] [PATCH 0/2] fix performance/cache resource issues with 128-byte " Thomas Monjalon
2015-12-07  7:26   ` Jerin Jacob
2015-12-07 11:40     ` Thomas Monjalon
2015-12-07 14:33       ` Jerin Jacob
2015-12-07 14:35         ` Thomas Monjalon
2015-12-10 16:36 ` [dpdk-dev] [PATCH v2 0/4] " Jerin Jacob
2015-12-10 16:36   ` [dpdk-dev] [PATCH v2 1/4] eal: Introduce new cache macro definitions Jerin Jacob
2015-12-10 16:36   ` [dpdk-dev] [PATCH v2 2/4] mbuf: fix performance/cache resource issue with 128-byte cache line targets Jerin Jacob
2015-12-10 16:36   ` [dpdk-dev] [PATCH v2 3/4] bitmap: optimize for 128-bytes " Jerin Jacob
2015-12-10 16:36   ` [dpdk-dev] [PATCH v2 4/4] cache/slow-path: reduce cache align requirement for 128-byte cache targets Jerin Jacob
2015-12-11 12:55     ` Ananyev, Konstantin
2015-12-11 13:07       ` Thomas Monjalon
2015-12-11 13:56       ` Jerin Jacob
2015-12-11 14:42         ` Ananyev, Konstantin
2015-12-14  4:32   ` [dpdk-dev] [PATCH v3 0/4] fix performance/cache resource issues with 128-byte cache line targets Jerin Jacob
2015-12-14  4:32     ` [dpdk-dev] [PATCH v3 1/4] eal: Introduce new cache macro definitions Jerin Jacob
2016-01-04 13:15       ` Olivier MATZ
2016-01-06 15:10         ` Jerin Jacob
2015-12-14  4:32     ` [dpdk-dev] [PATCH v3 2/4] mbuf: fix performance/cache resource issue with 128-byte cache line targets Jerin Jacob
2015-12-14  4:32     ` [dpdk-dev] [PATCH v3 3/4] bitmap: optimize for 128-bytes " Jerin Jacob
2015-12-14  4:32     ` [dpdk-dev] [PATCH v3 4/4] cache/slow-path: reduce cache align requirement for 128-byte cache targets Jerin Jacob
2016-01-29  7:45     ` [dpdk-dev] [PATCH v4 0/4] fix performance/cache resource issues with 128-byte cache line targets Jerin Jacob
2016-01-29  7:45       ` [dpdk-dev] [PATCH v4 1/4] eal: Introduce new cache line macro definitions Jerin Jacob
2016-01-29  7:45       ` [dpdk-dev] [PATCH v4 2/4] mbuf: fix performance/cache resource issue with 128-byte cache line targets Jerin Jacob
2016-01-29  7:45       ` [dpdk-dev] [PATCH v4 3/4] bitmap: optimize for 128-bytes " Jerin Jacob
2016-01-29  7:45       ` [dpdk-dev] [PATCH v4 4/4] cache/slow-path: reduce cache align requirement for 128-byte cache targets Jerin Jacob
2016-02-08  9:31       ` [dpdk-dev] [PATCH v4 0/4] fix performance/cache resource issues with 128-byte cache line targets Jerin Jacob
2016-02-08 10:24         ` Jan Viktorin
2016-02-08 10:52           ` Jerin Jacob [this message]
2016-02-08 12:56             ` Jan Viktorin
2016-02-11 11:53       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160208105216.GA14217@localhost.localdomain \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=viktorin@rehivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).