From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 77AB33195 for ; Mon, 8 Feb 2016 14:51:21 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 08 Feb 2016 05:51:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,416,1449561600"; d="scan'208";a="898620162" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.159]) by fmsmga001.fm.intel.com with SMTP; 08 Feb 2016 05:51:04 -0800 Received: by (sSMTP sendmail emulation); Mon, 08 Feb 2016 13:51:02 +0025 Date: Mon, 8 Feb 2016 13:51:02 +0000 From: Bruce Richardson To: Chas Williams <3chas3@gmail.com> Message-ID: <20160208135101.GA13952@bricha3-MOBL3> References: <1451522271-16924-1-git-send-email-3chas3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451522271-16924-1-git-send-email-3chas3@gmail.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, "Charles \(Chas\) Williams" , sony.chacko@qlogic.com Subject: Re: [dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2016 13:51:22 -0000 On Wed, Dec 30, 2015 at 07:37:50PM -0500, Chas Williams wrote: > From: "Charles (Chas) Williams" > > bnx2x_loop_obtain_resources() returns a struct containing the status and > the error message. If bnx2x_do_req4pf() fails, it shouldn't return both > of these fields set to 0 indicating failure and no error. > > Further, bnx2x_do_req4pf() needs to be able fail and return NO_RESOURCES > so that bnx2x_loop_obtain_resources() can negotiate reduced resource > requirments. This requires additional checking around bnx2x_do_req4pf(). > > Signed-off-by: Chas Williams <3chas3@gmail.com> > --- Hi Chas, can you please provide a commit reference for a fixes line for this patch. [No need for a V2 just for that alone, just the reference is enough to save me diving into the git history. I'll manually add the fixes line when committing to the next-net tree] Maintainers, can you please review this patchset and provide feedback or an ACK. Regards, /Bruce