From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4AD4595D0 for ; Tue, 9 Feb 2016 16:55:53 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 09 Feb 2016 07:55:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,421,1449561600"; d="scan'208";a="899409748" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.159]) by fmsmga001.fm.intel.com with SMTP; 09 Feb 2016 07:55:50 -0800 Received: by (sSMTP sendmail emulation); Tue, 09 Feb 2016 15:55:50 +0025 Date: Tue, 9 Feb 2016 15:55:50 +0000 From: Bruce Richardson To: Liming Sun Message-ID: <20160209155550.GB7248@bricha3-MOBL3> References: <1450813790-11874-3-git-send-email-lsun@ezchip.com> <1452263948-22485-1-git-send-email-lsun@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1452263948-22485-1-git-send-email-lsun@ezchip.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] driver/net/mpipe: add rte_vect.h and enable CONFIG_RTE_LIBRTE_LPM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2016 15:55:53 -0000 On Fri, Jan 08, 2016 at 09:39:07AM -0500, Liming Sun wrote: > rte_vect.h was missing earlier thus LPM was disabled and l3fwd is > not able to compile. This commit implements the vector api and > enable LPM in the tilegx configuration by default. It also includes > a minor optimization to use __insn_fetchadd4() instead of > rte_atomic32_xxx() in mpipe_dp_enter/mpipe_dp_exit to avoid the > unnecessary memory fence. This looks like it should be two patches to me. One patch to add the missing dependency and get lpm to work. The second patch should then contain the driver optimization. Do you agree? /Bruce PS: the commit title prefix for the first patch should probably be "eal/tile" rather than mpipe, since it's not directly affecting the mpipe driver. > > Signed-off-by: Liming Sun > Acked-by: Zhigang Lu > --- > config/defconfig_tile-tilegx-linuxapp-gcc | 2 +- > drivers/net/mpipe/mpipe_tilegx.c | 18 +++-- > lib/librte_eal/common/include/arch/tile/rte_vect.h | 93 ++++++++++++++++++++++ > 3 files changed, 107 insertions(+), 6 deletions(-) > create mode 100644 lib/librte_eal/common/include/arch/tile/rte_vect.h > [snip] >+ mbuf->next = NULL; > > PMD_DEBUG_RX("%s: RX mbuf %p, buffer %p, buf_addr %p, size %d\n", > mpipe_name(priv), mbuf, va, mbuf->buf_addr, size); > diff --git a/lib/librte_eal/common/include/arch/tile/rte_vect.h b/lib/librte_eal/common/include/arch/tile/rte_vect.h > new file mode 100644 > index 0000000..32d768a > --- /dev/null > +++ b/lib/librte_eal/common/include/arch/tile/rte_vect.h > @@ -0,0 +1,93 @@ > +/* > + * BSD LICENSE > + * > + * Copyright (C) EZchip Semiconductor Ltd. 2015. Maybe update the copyright year? > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions [snip]