From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 582AD2A5B
 for <dev@dpdk.org>; Wed, 10 Feb 2016 13:30:16 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga104.fm.intel.com with ESMTP; 10 Feb 2016 04:30:15 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,425,1449561600"; d="scan'208";a="743614542"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.159])
 by orsmga003.jf.intel.com with SMTP; 10 Feb 2016 04:30:13 -0800
Received: by  (sSMTP sendmail emulation); Wed, 10 Feb 2016 12:30:12 +0025
Date: Wed, 10 Feb 2016 12:30:12 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
 Yong Wang <yongwang@vmware.com>
Message-ID: <20160210123012.GA11040@bricha3-MOBL3>
References: <1452650917-7960-1-git-send-email-yongwang@vmware.com>
 <20160112205634.7bd2d50d@xeon-e3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160112205634.7bd2d50d@xeon-e3>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 0/6] vmxnet3 TSO,
 tx cksum offload and cleanups
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Feb 2016 12:30:16 -0000

On Tue, Jan 12, 2016 at 08:56:34PM -0800, Stephen Hemminger wrote:
> On Tue, 12 Jan 2016 18:08:31 -0800
> Yong Wang <yongwang@vmware.com> wrote:
> 
> > v4:
> > * moved cleanups to separate patches
> > * correctly handled multi-seg pkts with data ring used
> > 
> > v3:
> > * fixed comments from Stephen
> > * added performance number for tx data ring
> > 
> > v2:
> > * fixed some logging issues when debug option turned on
> > * updated the txq_flags check in vmxnet3_dev_tx_queue_setup()
> > 
> > This patchset adds TCP/UDP checksum offload and TSO to vmxnet3 PMD.
> > One of the use cases is to support STT.  It also restores the tx
> > data ring feature that was removed from a previous patch.
> > 
> > Yong Wang (6):
> >   vmxnet3: fix typos and remove unused struct
> >   vmxnet3: restore tx data ring support
> >   vmxnet3: cleanup txNumDeferred usage
> >   vmxnet3: add tx l4 cksum offload
> >   vmxnet3: add TSO support
> >   vmxnet3: announce device offload capability
> > 
> >  doc/guides/rel_notes/release_2_3.rst    |  11 +++
> >  drivers/net/vmxnet3/base/includeCheck.h |  39 --------
> >  drivers/net/vmxnet3/base/vmxnet3_defs.h |   9 +-
> >  drivers/net/vmxnet3/vmxnet3_ethdev.c    |  16 +++-
> >  drivers/net/vmxnet3/vmxnet3_ring.h      |  13 ---
> >  drivers/net/vmxnet3/vmxnet3_rxtx.c      | 160 +++++++++++++++++++++++++-------
> >  6 files changed, 151 insertions(+), 97 deletions(-)
> >  delete mode 100644 drivers/net/vmxnet3/base/includeCheck.h
> > 
> 
> Looks good. The only thing maybe worth adding would be some more checks
> int the vmxnet3_dev_configure for unsupported offload bits, etc.
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Applied to dpdk-next-net/rel_16_04

Thanks,
Bruce