From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] version: switch to year/month version numbers
Date: Wed, 10 Feb 2016 15:31:08 +0000 [thread overview]
Message-ID: <20160210153107.GA10620@bricha3-MOBL3> (raw)
In-Reply-To: <1877379.9acYIlBRDX@xps13>
On Wed, Feb 10, 2016 at 04:11:40PM +0100, Thomas Monjalon wrote:
> 2016-02-10 14:33, John McNamara:
> > /**
> > * Major version number i.e. the x in x.y.z
> > */
> > -#define RTE_VER_MAJOR 2
> > +#define RTE_VER_MAJOR 16
> >
> > /**
> > * Minor version number i.e. the y in x.y.z
> > */
> > -#define RTE_VER_MINOR 3
> > +#define RTE_VER_MINOR 4
> >
>
> I liked the idea of Bruce of renaming these constants to
> *_YEAR and *_MONTH.
> I also think RTE_VER_PATCH_LEVEL should be RTE_VER_MINOR.
> And maybe that RTE_VER_PATCH_RELEASE should be RTE_VER_RELEASE.
>
> It shouldn't hurt applications as they must use RTE_VERSION
> and rte_version().
>
> Opinions?
Well, I always tend to like Bruce's ideas too, so +1 from me :-)
/Bruce
next prev parent reply other threads:[~2016-02-10 15:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 13:26 [dpdk-dev] [PATCH 0/3] switch to using YY.MM " Bruce Richardson
2015-12-21 13:26 ` [dpdk-dev] [PATCH 1/3] version: switch to year/month " Bruce Richardson
2016-02-10 14:33 ` [dpdk-dev] [PATCH v2 1/2] " John McNamara
2016-02-10 14:33 ` [dpdk-dev] [PATCH v2 2/2] doc: rename release notes 2.3 to 16.04 John McNamara
2016-02-10 15:11 ` [dpdk-dev] [PATCH v2 1/2] version: switch to year/month version numbers Thomas Monjalon
2016-02-10 15:31 ` Bruce Richardson [this message]
2016-02-10 16:52 ` Mcnamara, John
2015-12-21 13:26 ` [dpdk-dev] [PATCH 2/3] version: adjust printing for new version scheme Bruce Richardson
2015-12-28 22:25 ` Thomas Monjalon
2016-02-10 14:28 ` Mcnamara, John
2015-12-21 13:26 ` [dpdk-dev] [PATCH 3/3] doc: rename release 2.3 to 16.04 Bruce Richardson
2016-02-10 17:02 ` [dpdk-dev] [PATCH v3 1/2] version: switch to year/month version numbers John McNamara
2016-02-10 17:02 ` [dpdk-dev] [PATCH v3 2/2] doc: rename release notes 2.3 to 16.04 John McNamara
2016-02-10 17:11 ` [dpdk-dev] [PATCH v3 1/2] version: switch to year/month version numbers Mcnamara, John
2016-02-10 17:20 ` Thomas Monjalon
2016-02-10 21:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210153107.GA10620@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).