DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] virtio: fix virtio_net_hdr desc pointing to the same buffer
@ 2015-12-10 16:07 Huawei
  2015-12-12  7:39 ` Tan, Jianfeng
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: Huawei @ 2015-12-10 16:07 UTC (permalink / raw)
  To: dev

The virtio_net_hdr desc all pointed to the same buffer. It doesn't cause
issue because in the simple TX mode we don't use the header. This patch
makes the header desc point to different buffer.

Signed-off-by: Huawei Xie <huawei.xie@intel.com>
---
 drivers/net/virtio/virtio_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index 74b39ef..6cfd315 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/drivers/net/virtio/virtio_rxtx.c
@@ -352,7 +352,7 @@ virtio_dev_vring_start(struct virtqueue *vq, int queue_type)
 				vq->vq_ring.desc[i + mid_idx].next = i;
 				vq->vq_ring.desc[i + mid_idx].addr =
 					vq->virtio_net_hdr_mem +
-						mid_idx * vq->hw->vtnet_hdr_size;
+						i * vq->hw->vtnet_hdr_size;
 				vq->vq_ring.desc[i + mid_idx].len =
 					vq->hw->vtnet_hdr_size;
 				vq->vq_ring.desc[i + mid_idx].flags =
-- 
1.8.1.4

^ permalink raw reply	[flat|nested] 14+ messages in thread
* [dpdk-dev] [PATCH 0/4] vhost: Fix various coverity issues in vhost library
@ 2015-12-10 17:57 Huawei
  2015-12-10 17:57 ` [dpdk-dev] [PATCH] virtio: fix virtio_net_hdr desc pointing to the same buffer Huawei
  0 siblings, 1 reply; 14+ messages in thread
From: Huawei @ 2015-12-10 17:57 UTC (permalink / raw)
  To: dev

Huawei Xie (4):
  vhost: Fix Coverity issue with possible array out-of-bounds read
  vhost: Fix Coverity issue with missed break in switch
  vhost: Fix Coverity issue with missed unlocking
  vhost: Fix Coverity issue with logically dead code

 lib/librte_vhost/vhost_user/fd_man.c         | 4 +++-
 lib/librte_vhost/vhost_user/vhost-net-user.c | 4 +++-
 lib/librte_vhost/virtio-net.c                | 3 +--
 3 files changed, 7 insertions(+), 4 deletions(-)

-- 
1.8.1.4

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2016-02-10 15:36 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-10 16:07 [dpdk-dev] [PATCH] virtio: fix virtio_net_hdr desc pointing to the same buffer Huawei
2015-12-12  7:39 ` Tan, Jianfeng
2015-12-14  1:21   ` Xie, Huawei
2015-12-14  1:35 ` Tan, Jianfeng
2015-12-14  3:01 ` Yuanhan Liu
2015-12-14  9:32   ` Thomas Monjalon
2015-12-14 11:47     ` Yuanhan Liu
2015-12-14 12:44       ` Thomas Monjalon
2015-12-14 13:09         ` Yuanhan Liu
2015-12-14 13:38           ` Xie, Huawei
2015-12-14 13:45             ` Thomas Monjalon
2015-12-14 13:58               ` Xie, Huawei
2016-02-10 15:36                 ` Bruce Richardson
2015-12-10 17:57 [dpdk-dev] [PATCH 0/4] vhost: Fix various coverity issues in vhost library Huawei
2015-12-10 17:57 ` [dpdk-dev] [PATCH] virtio: fix virtio_net_hdr desc pointing to the same buffer Huawei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).