From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6E4A793FA for ; Fri, 12 Feb 2016 13:16:40 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 12 Feb 2016 04:16:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,435,1449561600"; d="scan'208";a="651201308" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.63]) by FMSMGA003.fm.intel.com with SMTP; 12 Feb 2016 04:16:36 -0800 Received: by (sSMTP sendmail emulation); Fri, 12 Feb 2016 12:16:35 +0025 Date: Fri, 12 Feb 2016 12:16:35 +0000 From: Bruce Richardson To: Jingjing Wu Message-ID: <20160212121635.GC18808@bricha3-MOBL3> References: <1452480636-30155-1-git-send-email-jingjing.wu@intel.com> <1453280236-8778-1-git-send-email-jingjing.wu@intel.com> <1453280236-8778-2-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453280236-8778-2-git-send-email-jingjing.wu@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/3] i40e: enable DCB in VMDQ vsis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2016 12:16:40 -0000 On Wed, Jan 20, 2016 at 04:57:14PM +0800, Jingjing Wu wrote: > Previously, DCB is only enabled on PF, queue mapping and BW > configuration is only done on PF vsi. This patch enabled DCB > for VMDQ vsis by following steps: > 1. Take BW and ETS configuration on VEB. > 2. Take BW and ETS configuration on VMDQ vsis. > 3. Update TC and queues mapping on VMDQ vsis. > To enable DCB on VMDQ, the number of TCs should not be lager than typo: s/lager/larger/ > the number of queues in VMDQ pools, and the number of queues per > VMDQ pool is specified by CONFIG_RTE_LIBRTE_I40E_QUEUE_NUM_PER_VM > in config/common_* file. > > Signed-off-by: Jingjing Wu In the title and commit log, can you please capitalize the abbreviation VSI, so that VSIs is recognisable as a plural of the acronym, and not as the word "vsis", which confused me for a while. :-) Can you also explain what ETS stands for. [Not sure if VSI also needs to be expanded out the first time it is used in the message] > --- > doc/guides/rel_notes/release_2_3.rst | 2 + > drivers/net/i40e/i40e_ethdev.c | 153 ++++++++++++++++++++++++++++++----- > drivers/net/i40e/i40e_ethdev.h | 28 ++++--- > 3 files changed, 151 insertions(+), 32 deletions(-) > > diff --git a/doc/guides/rel_notes/release_2_3.rst b/doc/guides/rel_notes/release_2_3.rst > index 99de186..cd3d391 100644 > --- a/doc/guides/rel_notes/release_2_3.rst > +++ b/doc/guides/rel_notes/release_2_3.rst > @@ -4,6 +4,8 @@ DPDK Release 2.3 > New Features > ------------ > > +* **Added i40e DCB support in VMDQ mode.** Suggest to reword this as: "Added support for DCB in VMDQ mode to i40e driver" > + > > Resolved Issues > --------------- > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > index bf6220d..fbafcc6 100644 Thanks, /Bruce