From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8B8B295B5 for ; Fri, 12 Feb 2016 15:52:36 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 12 Feb 2016 06:52:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,436,1449561600"; d="scan'208";a="910774941" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.63]) by orsmga002.jf.intel.com with SMTP; 12 Feb 2016 06:52:33 -0800 Received: by (sSMTP sendmail emulation); Fri, 12 Feb 2016 14:52:32 +0025 Date: Fri, 12 Feb 2016 14:52:32 +0000 From: Bruce Richardson To: Jingjing Wu Message-ID: <20160212145232.GA12176@bricha3-MOBL3> References: <1453424966-5678-1-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453424966-5678-1-git-send-email-jingjing.wu@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] i40evf: enable ops to add and remove mac address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2016 14:52:37 -0000 On Fri, Jan 22, 2016 at 09:09:26AM +0800, Jingjing Wu wrote: > This patch implemented the ops of adding and removing mac > address in i40evf driver. Functions are assigned like: > .mac_addr_add = i40evf_add_mac_addr, > .mac_addr_remove = i40evf_del_mac_addr, > To support multiple mac addresses setting, this patch also > extended the mac addresses adding and deletion when device > start and stop. For each VF, 64 mac addresses can be added > to in maximum. > > Signed-off-by: Jingjing Wu Any comments on this patch? Helin, as maintainer of i40e, can you perhaps review and ack or comment on this. thanks, /Bruce