From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 009AD592A for ; Mon, 15 Feb 2016 06:53:18 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 14 Feb 2016 21:53:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,449,1449561600"; d="scan'208";a="912486806" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.66.49]) by orsmga002.jf.intel.com with ESMTP; 14 Feb 2016 21:53:17 -0800 Date: Mon, 15 Feb 2016 13:57:06 +0800 From: Yuanhan Liu To: Rich Lane Message-ID: <20160215055706.GA21426@yliu-dev.sh.intel.com> References: <1455132428-46926-1-git-send-email-rlane@bigswitch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455132428-46926-1-git-send-email-rlane@bigswitch.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] vhost: remove vhost_net_device_ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2016 05:53:19 -0000 On Wed, Feb 10, 2016 at 11:27:08AM -0800, Rich Lane wrote: > The indirection is unnecessary because there is only one implementation of the > vhost common code. Removing it makes the code more readable. This is a good cleanup! A minor nit is that I saw few long lines exceeding 80 chars. --yliu