From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 6BE7656B7 for ; Mon, 15 Feb 2016 09:46:57 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id g62so139013405wme.0 for ; Mon, 15 Feb 2016 00:46:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=cMAwDmE2ZZTSmdf3bP2vFE2E5ENMXPmqzatpRevpoKU=; b=b3ehNVXKvM1JBg+uuWm9OZDBgAeqcjz1YKH4E3phXqIawq6+z9oZ8syiWfnlzgh70A bCbbLN02WwODybxR4/oZIm8UHfbMknXs4YjgJqMlL9AgE6hLFNowszuYOWx/Kd+N1C7S hGGK6qkCUUgpdhD/6LLfZorjKy0J6eIixIjXYYH9d+92NinijckImnipvGFoMoVTcLVb qaep2F82RrxD7jlvWG8rp3dPtbNDoNpCIaQuajK9m+Efg41kkpnFNvwEpTaJxIhobk5a jhEGohAlrmSZFwGvts+AlGmuVWpPGXxu1ioUUjexJuKWCYYqXVjTbmDwqc4Ry4VtKfVW bzaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=cMAwDmE2ZZTSmdf3bP2vFE2E5ENMXPmqzatpRevpoKU=; b=Xkw/nwTcxbq4FYCNOrF9TZxcwTvS3abeHF5nAzRpW3EmFNNBkyY97Hxvv3ICt47Crk BRV+ZGbfPgJZTHnpLcA5jcnssWaXyMBxe2tDuIVb/K9pNtbA3meanP5Gt/P67E3J06Ot TsBa0Tn5fiIQFCyP9T5XLGktvEK2l7PmDkgBqtYBq0T9UMjmwTSzWXvHfo6JIpIyH7yQ kqY6a8lVJPKByNgkLqucIlNwkPovhMmUzkX7pFpbaCLdVeDiQdfu1KwreRvcvzav/NKr UQLjGx2BNwRB59BHOzO6tvhxJ3mHR5/Swf3baSEpjB1KHTldjIo4HLGpSIy8Ze1VjdbZ CSvA== X-Gm-Message-State: AG10YORq222r6CjD0JXk4X0kMvQCfbvwm8PJw6MVeiilrv6gHM3W4SpaDDj5hhFh0VKTjSgP X-Received: by 10.28.68.86 with SMTP id r83mr11862961wma.73.1455526017277; Mon, 15 Feb 2016 00:46:57 -0800 (PST) Received: from autoinstall.dev.6wind.com (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id t205sm14518000wmt.23.2016.02.15.00.46.56 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Feb 2016 00:46:56 -0800 (PST) Date: Mon, 15 Feb 2016 09:46:39 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Marc Sune Message-ID: <20160215084639.GL14424@autoinstall.dev.6wind.com> References: <1454028127-10401-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-1-git-send-email-marcdevel@gmail.com> <1455488259-1000-4-git-send-email-marcdevel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1455488259-1000-4-git-send-email-marcdevel@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v8 3/4] ethdev: redesign link speed config API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2016 08:46:57 -0000 On Sun, Feb 14, 2016 at 11:17:38PM +0100, Marc Sune wrote: > This patch redesigns the API to set the link speed/s configure > for an ethernet port. Specifically: > > - it allows to define a set of advertised speeds for > auto-negociation. > - it allows to disable link auto-negociation (single fixed speed). > - default: auto-negociate all supported speeds. > >[...] > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > index c5688a7..01c3a5c 100644 > --- a/drivers/net/mlx4/mlx4.c > +++ b/drivers/net/mlx4/mlx4.c > @@ -4265,8 +4265,8 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) > if (priv_get_ifname(priv, &ifname) == 0) > info->if_index = if_nametoindex(ifname); > > - info->speed_capa = ETH_SPEED_CAP_10G |ETH_SPEED_CAP_40G | > - ETH_SPEED_CAP_56G; > + info->speed_capa = ETH_LINK_SPEED_10G |ETH_LINK_SPEED_40G | > + ETH_LINK_SPEED_56G; > > priv_unlock(priv); > } > @@ -4636,6 +4636,8 @@ mlx4_link_update_unlocked(struct rte_eth_dev *dev, int wait_to_complete) > dev_link.link_speed = link_speed; > dev_link.link_duplex = ((edata.duplex == DUPLEX_HALF) ? > ETH_LINK_HALF_DUPLEX : ETH_LINK_FULL_DUPLEX); > + dev_link.link_autoneg = ~(dev->data->dev_conf.link_speeds & > + ETH_LINK_SPEED_NO_AUTONEG); > if (memcmp(&dev_link, &dev->data->dev_link, sizeof(dev_link))) { > /* Link status changed. */ > dev->data->dev_link = dev_link; >[...] The same modification are missing in mlx5. -- Nélio Laranjeiro 6WIND