From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9337A9A8F for ; Tue, 16 Feb 2016 11:11:57 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 16 Feb 2016 02:11:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,454,1449561600"; d="scan'208";a="747156167" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.63]) by orsmga003.jf.intel.com with SMTP; 16 Feb 2016 02:11:54 -0800 Received: by (sSMTP sendmail emulation); Tue, 16 Feb 2016 10:11:52 +0025 Date: Tue, 16 Feb 2016 10:11:52 +0000 From: Bruce Richardson To: Ziye Yang Message-ID: <20160216101152.GA24596@bricha3-MOBL3> References: <1453689419-237252-1-git-send-email-ziye.yang@intel.com> <1455596119-4613-1-git-send-email-ziye.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455596119-4613-1-git-send-email-ziye.yang@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] PCI: ABI change request for adding new field in rte_pci_id structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 10:11:58 -0000 On Tue, Feb 16, 2016 at 12:15:19PM +0800, Ziye Yang wrote: > From: Ziye > > The purpose of this patch is used to add a new field > "class" in rte_pci_id structure. The new class field includes > class_id, subcalss_id, programming interface of a pci device. > With this field, we can identify pci device by its class info, > which can be more flexible instead of probing the device by > vendor_id OR device_id OR subvendor_id OR subdevice_id. > For example, we can probe all nvme devices by class field, which > can be quite convenient. > > As release_2_3.rst is replaced with release_16_04.rst. > > Signed-off-by: Ziye Yang > --- > doc/guides/rel_notes/release_16_04.rst | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/rel_notes/release_16_04.rst b/doc/guides/rel_notes/release_16_04.rst > index 27fc624..fe843a5 100644 > --- a/doc/guides/rel_notes/release_16_04.rst > +++ b/doc/guides/rel_notes/release_16_04.rst > @@ -95,9 +95,10 @@ This section should contain API changes. Sample format: > ABI Changes > ----------- > > -* Add a short 1-2 sentence description of the ABI change that was announced in > - the previous releases and made in this release. Use fixed width quotes for > - ``rte_function_names`` or ``rte_struct_names``. Use the past tense. > +* New field ``class`` is added into ``rte_pci_id`` structure. This new > + added ``class`` field can be used to probe pci devices by class related > + info. With this new field, the size of structure ``rte_pci_device`` will > + be increased. > > > Shared Library Versions > -- Hi, since this is new ABI change announcement, and not one that was previously announced and is now being applied, this announcement should go in the deprecation.rst file, rather than release_16_04.rst. Thomas, is there some reason why the deprecation notices are not called out in the release notes for a new release? Why are they kept separately? /Bruce