From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id 4FE732A5E for ; Tue, 16 Feb 2016 19:54:41 +0100 (CET) Received: by mail-pa0-f41.google.com with SMTP id ho8so109243596pac.2 for ; Tue, 16 Feb 2016 10:54:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=hPDhlsDm/qQNJFYOiYoC7LpJ17sP0lWpkWLRA+7pUW4=; b=xEuMtQDG7qZFzDY2mFA+ggrSC1M9URxxC69ZwG0tdjYxi9KMAZDfpIgaeYWUqerIco meii2nGJM5rimktUMD1HXWshZuj7yyRs2Q7yK08/sL0MxLqK1bx8OeZg2BOOeTuDAhsg relzu6E9t05iKv9ygBMyK5FXVjs39VmjReQA0faF3hsAXv45U52rDfEB9OvLMGsnT1Si Mr8LcCNVkcoIVGtwoYrgHxtaJdzqCIvot50LZ9jgpfBgfFcl6Sfq8T5XccBuT+Ctqkdw DZ/yi6Ir1lBS4h7z99M2a0KhRVVreYzVbx7PVHuHbKeBHZa2GlrLPYG71koUcKHV9PX1 LA8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=hPDhlsDm/qQNJFYOiYoC7LpJ17sP0lWpkWLRA+7pUW4=; b=a5KtO8PMpwiMTRcMNCrf/d6niZg8RKddF4tqgekF/NvWRd99c6XQusY0ghhqGUf3gG UJ5Gl5VhBN1ImYdd2t18nSWu1ZWcq1d07dOu8Ta/zrUC7FmEz8qYyYqR8JO5xVqQ+FHU ybTdTJnphUdDsehbZHwmuI9c8++ofFbkPqUNuNKhGTZJGLFc88ROw3IfFcix56dAx3GE TF/4HST400B+yGu6jUvwPKedboAulrvJsjth+0y4HvmFMb8aZuVMi8K4jF1/kgeQ6YZl Ye4pXhGBwKrYKWirkfWFKAoMJj9e49xBpvEf6QVKAK9IZ66ScTEuIQRsbT5bdM0fTUHl cupg== X-Gm-Message-State: AG10YOT34jwYYXJdMBfErux1petoOrARRLsOVMOCKQhH+s9YNXwO8FzxRueni0hDa9rWkg== X-Received: by 10.66.193.202 with SMTP id hq10mr32437710pac.6.1455648880698; Tue, 16 Feb 2016 10:54:40 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id v29sm47487520pfa.31.2016.02.16.10.54.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Feb 2016 10:54:40 -0800 (PST) Date: Tue, 16 Feb 2016 10:54:52 -0800 From: Stephen Hemminger To: Remy Horton Message-ID: <20160216105452.0b1da99f@xeon-e3> In-Reply-To: <1453970895-2639-1-git-send-email-remy.horton@intel.com> References: <1453970895-2639-1-git-send-email-remy.horton@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 0/3] Add missing ethdev driver support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 18:54:41 -0000 On Thu, 28 Jan 2016 08:48:12 +0000 Remy Horton wrote: > Several rte_eth_dev_* functions are currently only supported > by the ixgbe NIC driver. This patchset adds driver support > for some of these functions to the i40e, virtio, and vmxnet3 > drivers. It is good to make drivers more complete and compatible, but unless the virtual driver has some useful data I can't see the point of providing these functions in this case. The base infrastructure (rte_ethdev) should deal with by returning not supported error (or all zeros); rather than creating more code in other drivers for no real gain.