From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5A88B37A6 for ; Tue, 16 Feb 2016 11:55:56 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 16 Feb 2016 02:55:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,455,1449561600"; d="scan'208";a="747174583" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.63]) by orsmga003.jf.intel.com with SMTP; 16 Feb 2016 02:55:52 -0800 Received: by (sSMTP sendmail emulation); Tue, 16 Feb 2016 10:55:51 +0025 Date: Tue, 16 Feb 2016 10:55:51 +0000 From: Bruce Richardson To: Wang Xiao W Message-ID: <20160216105551.GE21696@bricha3-MOBL3> References: <1453372561-11431-16-git-send-email-xiao.w.wang@intel.com> <1453866647-16215-1-git-send-email-xiao.w.wang@intel.com> <1453866647-16215-4-git-send-email-xiao.w.wang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1453866647-16215-4-git-send-email-xiao.w.wang@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 03/16] fm10k/base: cleanup namespace pollution and correct typecast X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2016 10:55:56 -0000 On Wed, Jan 27, 2016 at 11:50:34AM +0800, Wang Xiao W wrote: > Correct typecast in fm10k_update_xc_addr_pf. > > Make functions that are only referenced locally static. > > And fix the function header comment for fm10k_tlv_attr_nest_stop() while > we're at it. > > Wrap fm10k_msg_data fm10k_iov_msg_data_pf[] in the new ifndef > NO_DEFAULT_SRIOV_MSG_HANDLERS so that drivers with custom SR-IOV > message handlers can strip it. > > remove unused struct element in struct fm10k_mac_ops. > > Signed-off-by: Wang Xiao W > --- >>From the commit message it appears that a lot of things are being crammed into one patch. Please consider splitting it up, so that each commit just looks at doing one thing. If there are multiple one-line fixes, it's ok to put them into a single patch with a generic title like "misc small fixes", but for multi-line changes, it's best to have one change/fix per patch. Note also, that for commits fixing problems, a "fixes" line should be included in the commit message as documented here: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-body Thanks, /Bruce