From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 659B5C166 for ; Thu, 18 Feb 2016 10:50:49 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 18 Feb 2016 01:50:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,464,1449561600"; d="scan'208";a="50057385" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga004.fm.intel.com with ESMTP; 18 Feb 2016 01:50:47 -0800 Received: from sivlogin002.ir.intel.com (sivlogin002.ir.intel.com [10.237.217.37]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id u1I9oksn002861; Thu, 18 Feb 2016 09:50:46 GMT Received: from sivlogin002.ir.intel.com (localhost [127.0.0.1]) by sivlogin002.ir.intel.com with ESMTP id u1I9obBW012084; Thu, 18 Feb 2016 09:50:37 GMT Received: (from fyigit@localhost) by sivlogin002.ir.intel.com with œ id u1I9oaLk012077; Thu, 18 Feb 2016 09:50:36 GMT X-Authentication-Warning: sivlogin002.ir.intel.com: fyigit set sender to ferruh.yigit@intel.com using -f Date: Thu, 18 Feb 2016 09:50:36 +0000 From: Ferruh Yigit To: Bruce Richardson Message-ID: <20160218095036.GA1524@sivlogin002.ir.intel.com> Mail-Followup-To: Bruce Richardson , dev@dpdk.org, Tetsuya Mukawa , =?iso-8859-1?Q?Nicol=E1s?= Pernas Maradei References: <1454087782-15085-1-git-send-email-ferruh.yigit@intel.com> <1454087782-15085-3-git-send-email-ferruh.yigit@intel.com> <20160217173655.GD11736@bricha3-MOBL3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160217173655.GD11736@bricha3-MOBL3> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: dev@dpdk.org, =?iso-8859-1?Q?Nicol=E1s?= Pernas Maradei Subject: Re: [dpdk-dev] [PATCH 2/3] ring: remove duplicate fields in internal data struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2016 09:50:49 -0000 On Wed, Feb 17, 2016 at 05:36:55PM +0000, Bruce Richardson wrote: > On Fri, Jan 29, 2016 at 05:16:21PM +0000, Ferruh Yigit wrote: > > 1- Remove duplicate nb_rx/tx_queues fields from internals > > 2- Remove data->rx/tx_queues allocation, whose auto allocated by > > libether > > 3- Remove duplicate data->rx/tx_queues[i] assignments > > > > Signed-off-by: Ferruh Yigit > > --- > > drivers/net/ring/rte_eth_ring.c | 52 +++++++++++------------------------------ > > 1 file changed, 14 insertions(+), 38 deletions(-) > > > > Hi Ferruh, Hi Bruce, > > does this patch not break rte_eth_from_ring() and rte_eth_from_rings() since > the "auto allocation" you refer to is only performed on eth_dev_configure, I > believe. Currently, you can create an rte_ring and then use it as though it > were an ethdev by calling: > port_id = rte_eth_from_ring(r) > > With this change, I believe the user instead has to now call eth_from_ring, > then do a series of configure and queue setup calls just to make the new > ethdev usable. > I wasn't aware requirement to use without config and setup calls, yes this patch breaks it. I will update the patch to recover this kind of usage. Thanks, ferruh