From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) by dpdk.org (Postfix) with ESMTP id 64C52C5A8 for ; Sun, 21 Feb 2016 06:35:33 +0100 (CET) Received: by mail-pa0-f42.google.com with SMTP id fl4so72962808pad.0 for ; Sat, 20 Feb 2016 21:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=MkFnVEUpAZPrOcA5MlqCWMs95q1c+y+Z+80Ra4VFbY0=; b=UsJHTpz7MsTQzdtMhBpLpSOkG0vBm+wCGWl8qxno9rn8V4w8NoMJ6CUfPG+kLp5QL7 FNAdBcMAHTImnmHbhHCu2yiWIG0RYXOZqmuw+erRFFQUn0HCxsbUjtscxi6dBmuqvrZ6 PDLrqujVDirc8TWH20lEO2Q7XYhBssxtSYBHGUlMs0yzwApFrygoexwQlrIqPfYgQJYD IZqGhsTMjsMtDpm+eNoiJLmFFNatZKmKBsTOH6sZyAyYSFVHHWm+pr3eVZKoerzNi/dx sZIvE7FjL79hRqNjzY5aqGygpuCTnHaReqTB0ffudAnBeGGdhAMVzX7mAsua6jOEunKy nQ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=MkFnVEUpAZPrOcA5MlqCWMs95q1c+y+Z+80Ra4VFbY0=; b=X+UOobF/WhtTA6uuYjOCQbfNEwJ9EehNsPAzok7DgWMuBFQTpZyoj8UyUQGbTCyZxv FkiVDvwyk+nNQtml/ThlewLTpoG/xTrVbl43K+HoenvkeU2g1hI5iQooJldim1RUsDew tDszYSZGClQEcpFyZfyCYSs1feTtbzWiyyDC+L41b6SkhkLV3uvF1V5vQBC32FzIl97Q 3x0X+1WIZzsLl7fLlV5JhBnuWibCy6oaUPiKBGmGOho9wX2Itcl2+OB9x9MjMcJ4L8Lx qsgRN2lnYkArVdJI0RZBVyClPOjRLAa3WAa8k6n/drjMBZRrWVsmFtyR6bfQWibj83rD tiog== X-Gm-Message-State: AG10YOR8UWMtpmP2NKrFX4EuKLxcz3YQlw2xDtUwYYaJDp5Ga4usRgrNNNssTCamNyybXw== X-Received: by 10.67.7.169 with SMTP id dd9mr28539716pad.105.1456018132309; Sat, 20 Feb 2016 17:28:52 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id f12sm26991157pfd.87.2016.02.20.17.28.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 20 Feb 2016 17:28:52 -0800 (PST) Date: Sat, 20 Feb 2016 17:29:03 -0800 From: Stephen Hemminger To: Message-ID: <20160220172903.52db2811@xeon-e3> In-Reply-To: <1455983911-17812-1-git-send-email-harish.patil@qlogic.com> References: <1455983911-17812-1-git-send-email-harish.patil@qlogic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, Sony Chacko Subject: Re: [dpdk-dev] [PATCH 4/6] qede: add driver common module X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Feb 2016 05:35:33 -0000 On Sat, 20 Feb 2016 07:58:31 -0800 wrote: > +unsigned long log2_align(unsigned long n) > +{ Common code is good, but you need to practice good function name hygiene on public functions to avoid any namespace clashes when using static linking. The application might define a function with log2_align. Either make the functions static, or use a common prefix for all qede internal functions.