From: Stephen Hemminger <stephen@networkplumber.org>
To: Harish Patil <harish.patil@qlogic.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Sony Chacko <sony.chacko@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH 5/6] qede: add driver
Date: Mon, 22 Feb 2016 21:30:46 -0800 [thread overview]
Message-ID: <20160222213046.294ffba4@xeon-e3> (raw)
In-Reply-To: <D2F0D889.157D8E%harish.patil@qlogic.com>
On Tue, 23 Feb 2016 02:28:25 +0000
Harish Patil <harish.patil@qlogic.com> wrote:
> All of the checkpatch warnings had been fixed (except one which cannot be
> fixed) using the checkpatch script available under DPDK scripts/
> directory. The linux checkpatch version is 0.32.
>
> [root@dut4019 dpdk]# ./scripts/checkpatches.sh patches-send/*.patch
>
> ### patches-send/0004-qede-add-driver-common-module.patch
>
> WARNING:CAMELCASE: Avoid CamelCase: <inflateEnd>
> #251: FILE: drivers/net/qede/ecore/bcm_osal.c:120:
> + inflateEnd(p_hwfn->stream);
>
> total: 0 errors, 1 warnings, 54467 lines checked
>
> Wouldn’t that suffice?
The problem is that the DPDK version is shutting off warnings about stuff
that is really incorrect and should be fixed.
Look at the warnings about spaces in strings, I don't know why the DPDK wrapper
disables that.
next prev parent reply other threads:[~2016-02-23 5:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-20 15:40 [dpdk-dev] [PATCH 0/6] DPDK PMD for new QLogic FastLinQ QL4xxxx 25G/40G CNAs Harish Patil
2016-02-20 15:40 ` [dpdk-dev] [PATCH 1/6] qede: add maintainers Harish Patil
2016-02-20 15:40 ` [dpdk-dev] [PATCH 2/6] qede: add documentation Harish Patil
2016-02-22 16:52 ` Mcnamara, John
2016-02-24 7:17 ` Harish Patil
2016-02-24 9:26 ` Mcnamara, John
2016-02-22 17:38 ` Mcnamara, John
2016-02-20 15:40 ` [dpdk-dev] [PATCH 3/6] qede: add QLogic PCI ids Harish Patil
2016-02-21 1:17 ` Stephen Hemminger
2016-02-22 23:23 ` Harish Patil
2016-02-20 15:40 ` [dpdk-dev] [PATCH 5/6] qede: add driver Harish Patil
2016-02-21 1:26 ` Stephen Hemminger
2016-02-23 2:28 ` Harish Patil
2016-02-23 5:30 ` Stephen Hemminger [this message]
2016-02-23 5:33 ` Stephen Hemminger
2016-02-23 19:04 ` Harish Patil
2016-02-23 19:06 ` Harish Patil
2016-02-20 15:40 ` [dpdk-dev] [PATCH 6/6] qede: enable PMD build Harish Patil
2016-02-20 20:49 ` [dpdk-dev] [PATCH 0/6] DPDK PMD for new QLogic FastLinQ QL4xxxx 25G/40G CNAs Thomas Monjalon
2016-02-22 16:47 ` Harish Patil
2016-02-22 17:35 ` Thomas Monjalon
2016-02-23 18:13 ` Harish Patil
2016-03-08 14:01 ` Bruce Richardson
2016-03-08 14:24 ` Harish Patil
2016-03-10 17:22 ` Harish Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222213046.294ffba4@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).