From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id A06F45683 for ; Tue, 23 Feb 2016 06:30:35 +0100 (CET) Received: by mail-pf0-f177.google.com with SMTP id x65so105755573pfb.1 for ; Mon, 22 Feb 2016 21:30:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=C13P4JR8P3933ceEWgHY2O4ja3OzqrQLFD3j+TEB0L0=; b=ScZjuXgmEm3s3AhKaAsTku4C5aFdE/CITCAHa85t3w2CMlc6t9K/h4A+cnWc4DUioL 0fFW6wCMavTueYbigJ9Ef7lD8j2nizSRKJBc5z7WGD2LvqeCxRLNmRhy1RloNU1ZNzdq JRtBU/6XfXAnaS5sEU8s6rH35mOp3IWlrw09StHn08B/55ge7yJsEAvUtk0QbkoPbEl/ v657vBMiGDX+vmWgzoQF4o8gqQ6Zzo/FmgXoTfjxrkSi2nVS4WvKYw7Xbp44v+mW62MU 4uGQ3ZZyZ+8lwJjzzWg58B6GguFXkbDbtcJmm7uwHEFkVtdx0Ovvji3jn48pU+ABlqmO w2xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=C13P4JR8P3933ceEWgHY2O4ja3OzqrQLFD3j+TEB0L0=; b=HnA2Z9Nwg8u/rY3MrDHrM6I4ehI9x3ooiNQTVcih69RDqw6wdv9/Tk2QIXadANYLju uYvjLZd6tiG92QShwWf9IcA+bA5z9yP0AD2RRRFojzg8iDzlAsYl5h2kAeMMoK9XJblB dYp9u99pWcdJJPKAkw342ZKv1ZffCQr6aZsxelTP8A6qB1OikYAEhei0JA7RIU0zhN6o AQJ5GP+fM41tU/XZhmjZsINbnx+Ds3ke5f+lIvwtKKNHfNG08DDMyVL1ygqIFAkIgHII jvV7UvMgMhaNNIhV7owtRLfg6u/HEdppqACmIL8kGjfIsGWYF0HLbhzI5mqO9gFKc+Et fI6w== X-Gm-Message-State: AG10YOTbDmp0uPx1AubaHJaW5sbH2eVWdEFhzD5dPl2WVyO04w3truPH1wTdJeALaKYLQQ== X-Received: by 10.98.34.25 with SMTP id i25mr43800689pfi.26.1456205435018; Mon, 22 Feb 2016 21:30:35 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id dg12sm40798494pac.47.2016.02.22.21.30.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Feb 2016 21:30:34 -0800 (PST) Date: Mon, 22 Feb 2016 21:30:46 -0800 From: Stephen Hemminger To: Harish Patil Message-ID: <20160222213046.294ffba4@xeon-e3> In-Reply-To: References: <1455982831-21682-1-git-send-email-harish.patil@qlogic.com> <1455982831-21682-6-git-send-email-harish.patil@qlogic.com> <20160220172623.5101c7e4@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Sony Chacko Subject: Re: [dpdk-dev] [PATCH 5/6] qede: add driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2016 05:30:36 -0000 On Tue, 23 Feb 2016 02:28:25 +0000 Harish Patil wrote: > All of the checkpatch warnings had been fixed (except one which cannot be > fixed) using the checkpatch script available under DPDK scripts/ > directory. The linux checkpatch version is 0.32. >=20 > [root@dut4019 dpdk]# ./scripts/checkpatches.sh patches-send/*.patch >=20 > ### patches-send/0004-qede-add-driver-common-module.patch >=20 > WARNING:CAMELCASE: Avoid CamelCase: > #251: FILE: drivers/net/qede/ecore/bcm_osal.c:120: > + inflateEnd(p_hwfn->stream); >=20 > total: 0 errors, 1 warnings, 54467 lines checked >=20 > Wouldn=E2=80=99t that suffice? The problem is that the DPDK version is shutting off warnings about stuff that is really incorrect and should be fixed. Look at the warnings about spaces in strings, I don't know why the DPDK wra= pper disables that.