From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id C1BD56C9D for ; Tue, 23 Feb 2016 06:33:12 +0100 (CET) Received: by mail-pf0-f178.google.com with SMTP id q63so105730995pfb.0 for ; Mon, 22 Feb 2016 21:33:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=pMjof18K9Zefq/uBi+B2WeTjiw/k347lgJBGoyKceVo=; b=RsGTeGd7uH5zX69lv2QVg1YR6VmKnTQwO6wuqOTNmX3WfkdoBh3TnAW/ZjCMTcznR/ NVJYFaZsnqsYPd4lYIm+8sOzZneB+Vx+mt/pIRC03ssSddmupf1RSL86zt1crRe8FjKd QPc4pbA37mc1NQ+qajDubpPgSTGLKs9UL+WNmpG9D+iJWoVRTB73B2mgI5BCB+KsCsId gqR4ewAjy3fGMYG2/8fwLtRSlqMhaOU7J5ngjL+xsvKrcXqlEf6hdJeakVdLRLCui3ol EsXRJWnHU1fo5r1DlipjlNSorBK7HdpO/RBkTH42WVxLDA4tnM6acVfJ16ouPW0nVK/X sbww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=pMjof18K9Zefq/uBi+B2WeTjiw/k347lgJBGoyKceVo=; b=b6XvceBcVZlIaNV++wZg6heC2hUR43dW1PRd87/prHsSVpBu4JPtbZk2jwAW8uLTO8 vtxnF6ZPl06+JZ0Ki9xU7U3sYSpf4qpicC4kY541U5Q4hf0Lnnc91BVDWAMm5U9s9J7t fWlYmv/IDzMoEa2uiB9+w8irw6s8tnLqyoH+7LyoaJjqVriU1XDDP3mlQyIoVZFR/Yp8 8ldtYjLnoFKM1wDfpLdbJl1rlfkL3xVeuTfn4Q4yAXXAZEaiKZoZMlVUOzYqopO+IhuM gxGuoBiDv0Dn5gqTJIP1N3mYy02XJ6xBWZkk7GKTwhrtDn0v0LYlpCUgz/H5/LXBbKEa +tmw== X-Gm-Message-State: AG10YORxMi3R1cKOnZfeF0nHWb8vIabQ4qD0oZKmjL3wHJfRGZuAOoOLjCBFUhPHsVgn9w== X-Received: by 10.98.67.92 with SMTP id q89mr43779403pfa.137.1456205592209; Mon, 22 Feb 2016 21:33:12 -0800 (PST) Received: from xeon-e3 (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by smtp.gmail.com with ESMTPSA id ac1sm8325216pad.41.2016.02.22.21.33.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Feb 2016 21:33:12 -0800 (PST) Date: Mon, 22 Feb 2016 21:33:23 -0800 From: Stephen Hemminger To: Harish Patil Message-ID: <20160222213323.5c0e2205@xeon-e3> In-Reply-To: References: <1455982831-21682-1-git-send-email-harish.patil@qlogic.com> <1455982831-21682-6-git-send-email-harish.patil@qlogic.com> <20160220172623.5101c7e4@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , Sony Chacko Subject: Re: [dpdk-dev] [PATCH 5/6] qede: add driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2016 05:33:13 -0000 On Tue, 23 Feb 2016 02:28:25 +0000 Harish Patil wrote: > All of the checkpatch warnings had been fixed (except one which cannot be > fixed) using the checkpatch script available under DPDK scripts/ > directory. The linux checkpatch version is 0.32. >=20 > [root@dut4019 dpdk]# ./scripts/checkpatches.sh patches-send/*.patch >=20 > ### patches-send/0004-qede-add-driver-common-module.patch >=20 > WARNING:CAMELCASE: Avoid CamelCase: > #251: FILE: drivers/net/qede/ecore/bcm_osal.c:120: > + inflateEnd(p_hwfn->stream); >=20 > total: 0 errors, 1 warnings, 54467 lines checked >=20 > Wouldn=E2=80=99t that suffice? Maybe your version of checkpatch from kernel is older than more recent version I am using (from Linux 4.4).