From: Bruce Richardson <bruce.richardson@intel.com>
To: Helin Zhang <helin.zhang@intel.com>
Cc: dev@dpdk.org, zhe.tag@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 1/3] i40e: enable extended tag
Date: Tue, 23 Feb 2016 10:44:46 +0000 [thread overview]
Message-ID: <20160223104446.GA15436@bricha3-MOBL3> (raw)
In-Reply-To: <1456113585-15259-2-git-send-email-helin.zhang@intel.com>
On Mon, Feb 22, 2016 at 11:59:43AM +0800, Helin Zhang wrote:
> PCIe feature of 'Extended Tag' is important for 40G performance.
> It adds its enabling during each port initialization, to ensure
> the high performance.
>
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
> doc/guides/rel_notes/release_16_04.rst | 6 ++++
> drivers/net/i40e/i40e_ethdev.c | 65 ++++++++++++++++++++++++++++++++--
> 2 files changed, 68 insertions(+), 3 deletions(-)
>
> v2:
> - Changed the type of return value of i40e_enable_extended_tag() to 'void'.
>
> diff --git a/doc/guides/rel_notes/release_16_04.rst b/doc/guides/rel_notes/release_16_04.rst
> index 5786f74..bed5779 100644
> --- a/doc/guides/rel_notes/release_16_04.rst
> +++ b/doc/guides/rel_notes/release_16_04.rst
> @@ -46,6 +46,12 @@ This section should contain new features added in this release. Sample format:
>
> * **Added vhost-user live migration support.**
>
> +* **i40e: Enabled extended tag.**
> +
> + It enabled extended tag by checking and writing corresponding PCI config
> + space bytes, to boost the performance. In the meanwhile, it deprecated the
> + legacy way via reading/writing sysfile supported by kernel module of igb_uio.
> +
Hi Helin,
does this really need to go into the release notes? Is it a user-visible change
that affects the user experience in any way?
/Bruce
next prev parent reply other threads:[~2016-02-23 10:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 2:38 [dpdk-dev] [PATCH 0/3] " Helin Zhang
2015-12-21 2:38 ` [dpdk-dev] [PATCH 1/3] " Helin Zhang
2016-01-22 1:34 ` Wu, Jingjing
2016-01-22 10:26 ` Thomas Monjalon
2016-01-24 3:25 ` Zhang, Helin
2016-01-25 9:16 ` Thomas Monjalon
2016-01-26 0:29 ` Zhang, Helin
2015-12-21 2:38 ` [dpdk-dev] [PATCH 2/3] eal: remove pci config of " Helin Zhang
2016-02-22 3:59 ` [dpdk-dev] [PATCH v2 0/3] enable extended tag for i40e Helin Zhang
2016-02-22 3:59 ` [dpdk-dev] [PATCH v2 1/3] i40e: enable extended tag Helin Zhang
2016-02-23 10:44 ` Bruce Richardson [this message]
2016-02-24 0:39 ` Zhang, Helin
2016-02-22 3:59 ` [dpdk-dev] [PATCH v2 2/3] eal: remove pci config of " Helin Zhang
2016-03-08 17:05 ` Thomas Monjalon
2016-02-22 3:59 ` [dpdk-dev] [PATCH v2 3/3] igb_uio: deprecate sys files Helin Zhang
2016-03-08 17:48 ` Thomas Monjalon
2016-03-08 18:02 ` Thomas Monjalon
2016-02-22 5:52 ` [dpdk-dev] [PATCH v2 0/3] enable extended tag for i40e Wu, Jingjing
2016-03-08 18:38 ` [dpdk-dev] [PATCH v3 " Thomas Monjalon
2016-03-08 18:38 ` [dpdk-dev] [PATCH v3 1/3] i40e: enable extended tag Thomas Monjalon
2016-03-08 18:38 ` [dpdk-dev] [PATCH v3 2/3] pci: remove config of " Thomas Monjalon
2016-03-08 18:38 ` [dpdk-dev] [PATCH v3 3/3] igb_uio: deprecate " Thomas Monjalon
2016-03-08 18:41 ` [dpdk-dev] [PATCH v3 0/3] enable extended tag for i40e Thomas Monjalon
2016-03-09 0:48 ` Zhang, Helin
2016-03-09 0:50 ` Thomas Monjalon
2016-03-09 0:52 ` Thomas Monjalon
2015-12-21 2:38 ` [dpdk-dev] [PATCH 3/3] igb_uio: remove sys files for setting pci config space Helin Zhang
2015-12-21 18:57 ` Stephen Hemminger
2016-02-22 6:31 ` [dpdk-dev] [PATCH v2 0/3] enable extended tag for i40e Helin Zhang
2016-02-22 6:31 ` [dpdk-dev] [PATCH v2 1/3] i40e: enable extended tag Helin Zhang
2016-02-22 6:31 ` [dpdk-dev] [PATCH v2 2/3] eal: remove pci config of " Helin Zhang
2016-02-22 6:31 ` [dpdk-dev] [PATCH v2 3/3] igb_uio: deprecate sys files Helin Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223104446.GA15436@bricha3-MOBL3 \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=zhe.tag@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).