From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B780E2BDB for ; Tue, 23 Feb 2016 11:44:50 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 23 Feb 2016 02:44:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,488,1449561600"; d="scan'208";a="919203266" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.64]) by orsmga002.jf.intel.com with SMTP; 23 Feb 2016 02:44:47 -0800 Received: by (sSMTP sendmail emulation); Tue, 23 Feb 2016 10:44:47 +0025 Date: Tue, 23 Feb 2016 10:44:46 +0000 From: Bruce Richardson To: Helin Zhang Message-ID: <20160223104446.GA15436@bricha3-MOBL3> References: <1450665486-8335-3-git-send-email-helin.zhang@intel.com> <1456113585-15259-1-git-send-email-helin.zhang@intel.com> <1456113585-15259-2-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456113585-15259-2-git-send-email-helin.zhang@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, zhe.tag@intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/3] i40e: enable extended tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2016 10:44:51 -0000 On Mon, Feb 22, 2016 at 11:59:43AM +0800, Helin Zhang wrote: > PCIe feature of 'Extended Tag' is important for 40G performance. > It adds its enabling during each port initialization, to ensure > the high performance. > > Signed-off-by: Helin Zhang > --- > doc/guides/rel_notes/release_16_04.rst | 6 ++++ > drivers/net/i40e/i40e_ethdev.c | 65 ++++++++++++++++++++++++++++++++-- > 2 files changed, 68 insertions(+), 3 deletions(-) > > v2: > - Changed the type of return value of i40e_enable_extended_tag() to 'void'. > > diff --git a/doc/guides/rel_notes/release_16_04.rst b/doc/guides/rel_notes/release_16_04.rst > index 5786f74..bed5779 100644 > --- a/doc/guides/rel_notes/release_16_04.rst > +++ b/doc/guides/rel_notes/release_16_04.rst > @@ -46,6 +46,12 @@ This section should contain new features added in this release. Sample format: > > * **Added vhost-user live migration support.** > > +* **i40e: Enabled extended tag.** > + > + It enabled extended tag by checking and writing corresponding PCI config > + space bytes, to boost the performance. In the meanwhile, it deprecated the > + legacy way via reading/writing sysfile supported by kernel module of igb_uio. > + Hi Helin, does this really need to go into the release notes? Is it a user-visible change that affects the user experience in any way? /Bruce