From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E2D382934 for ; Tue, 23 Feb 2016 16:27:51 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 23 Feb 2016 07:26:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,489,1449561600"; d="scan'208";a="919377633" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.64]) by orsmga002.jf.intel.com with SMTP; 23 Feb 2016 07:26:57 -0800 Received: by (sSMTP sendmail emulation); Tue, 23 Feb 2016 15:26:55 +0025 Date: Tue, 23 Feb 2016 15:26:55 +0000 From: Bruce Richardson To: Ferruh Yigit Message-ID: <20160223152654.GC17644@bricha3-MOBL3> References: <1454087782-15085-1-git-send-email-ferruh.yigit@intel.com> <1455794803-20383-1-git-send-email-ferruh.yigit@intel.com> <1455794803-20383-3-git-send-email-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455794803-20383-3-git-send-email-ferruh.yigit@intel.com> Organization: Intel Shannon Ltd. User-Agent: Mutt/1.5.23 (2014-03-12) Cc: dev@dpdk.org, =?iso-8859-1?Q?Nicol=E1s?= Pernas Maradei Subject: Re: [dpdk-dev] [PATCH v2 2/3] ring: remove duplicate fields in internal data struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2016 15:27:52 -0000 On Thu, Feb 18, 2016 at 11:26:42AM +0000, Ferruh Yigit wrote: > 1- Remove duplicate nb_rx/tx_queues fields from internals > > Signed-off-by: Ferruh Yigit > --- > drivers/net/ring/rte_eth_ring.c | 57 ++++++++++++++++++----------------------- > 1 file changed, 25 insertions(+), 32 deletions(-) > > diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c > index d92b088..fd87999 100644 > --- a/drivers/net/ring/rte_eth_ring.c > +++ b/drivers/net/ring/rte_eth_ring.c > @@ -59,9 +59,6 @@ struct ring_queue { > }; > > struct pmd_internals { > - unsigned nb_rx_queues; > - unsigned nb_tx_queues; > - > struct ring_queue rx_ring_queues[RTE_PMD_RING_MAX_RX_RINGS]; > struct ring_queue tx_ring_queues[RTE_PMD_RING_MAX_TX_RINGS]; > > @@ -138,7 +135,7 @@ eth_dev_set_link_up(struct rte_eth_dev *dev) > } > > static int > -eth_rx_queue_setup(struct rte_eth_dev *dev,uint16_t rx_queue_id, > +eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id, > uint16_t nb_rx_desc __rte_unused, > unsigned int socket_id __rte_unused, > const struct rte_eth_rxconf *rx_conf __rte_unused, > @@ -165,40 +162,39 @@ static void > eth_dev_info(struct rte_eth_dev *dev, > struct rte_eth_dev_info *dev_info) > { > - struct pmd_internals *internals = dev->data->dev_private; > dev_info->driver_name = drivername; > dev_info->max_mac_addrs = 1; > dev_info->max_rx_pktlen = (uint32_t)-1; > - dev_info->max_rx_queues = (uint16_t)internals->nb_rx_queues; > - dev_info->max_tx_queues = (uint16_t)internals->nb_tx_queues; > + dev_info->max_rx_queues = dev->data->nb_rx_queues; > + dev_info->max_tx_queues = dev->data->nb_tx_queues; I'm still not convined this is correct. What happens if a ring PMD is created with 16 queues (i.e. backed by 16 rings), and then the user uses rte_eth_dev_configure to only actually use 4 queues. The fact that the internal array still has 16 queues will be lost, and the device will only ever report 4 as the max number it can support. Regards, /Bruce