From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 1F1BA2A6C
 for <dev@dpdk.org>; Tue, 23 Feb 2016 18:31:11 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by orsmga101.jf.intel.com with ESMTP; 23 Feb 2016 09:31:09 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,490,1449561600"; d="scan'208";a="919476110"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.208.64])
 by orsmga002.jf.intel.com with SMTP; 23 Feb 2016 09:31:07 -0800
Received: by  (sSMTP sendmail emulation); Tue, 23 Feb 2016 17:31:06 +0025
Date: Tue, 23 Feb 2016 17:31:06 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Message-ID: <20160223173105.GA14460@bricha3-MOBL3>
References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com>
 <1452836759-63540-1-git-send-email-jianfeng.tan@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1452836759-63540-1-git-send-email-jianfeng.tan@intel.com>
Organization: Intel Shannon Ltd.
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 00/12] Add API to get packet type info
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Feb 2016 17:31:12 -0000

On Fri, Jan 15, 2016 at 01:45:47PM +0800, Jianfeng Tan wrote:
> A new ether API rte_eth_dev_get_ptype_info() is added to query what
> packet type information will be provided by current pmd driver of the
> specifed port.
> 
> To achieve this, a new function pointer, dev_ptype_info_get, is added
> into struct eth_dev_ops. For those devices who do not implement it, it
> means it will not provide any ptype info.
> 
> v2:
>   - Move ptype_mask filter function from each PMDs into ether layer.
>   - Add ixgbe vPMD's ptype info.
>   - Fix code style issues.
>
Hi,

there are some outstanding comments on these patches. Can you send a V3 to
resolve them?

/Bruce